typo: bundle jar with unrecognized variables

[yaooqinn]

When built master branch I got such kind of jars: hoodie-spark-bundle-0.4.5-SNAPSHOT${hiveJarSuffix}.jar

The hiveJarSuffix variable seems to be removed in previous commits.

[bvaradar]

Thanks @yaooqinn for the contribution.

The HiveJarSuffix should be replaced by empty string unless we pass -Dhive11. It seems weird that this is not happening in your environment. What is the mvn command and version used to build hoodie ?

FYI - As part of this PR (#563) , we have changed the maven settings to not use profiles (and suffix).

[yaooqinn]

mvn clean install -DskipTests -DskipIT

I build master branch using the above cmd, and I guess the reason might be found 3a00442#diff-a004dc49fe15830afc2f55bedfc7c50cL208

[vinothchandar]

@bvaradar ^^ ?

[bvaradar]

@yaooqinn : My mvn version is
varadarb-C02SH0P1G8WL:hudi varadarb$ mvn -version
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)

In this case, for the mvn setting <hiveJarSuffix />, the variable translated to empty string which was the expected case. Anyways, the referenced PR is merged now. So the problem hopefully is moot.

Let me know if the jar names are fine after you pull the latest changes.

[yaooqinn]

with

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-25T02:41:47+08:00)

to build the latest revision - 639c287, I still got hoodie-spark-bundle-0.4.5-SNAPSHOT${hiveJarSuffix}.jar

[louisliu318]

I came across the same problem as @yaooqinn

[bvaradar]

@yaooqinn : You are right. Thanks for fixing it. My CDH changes did not completely remove this variable. I can also see the issue.

@vinothchandar : If you are ok with this change, I will merge it. THis needs to be done before we cut release.