Make HoodieDeltaStreamer hive-sync to CDH Hive Servers #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaradar
changed the title
bvaradar
force-pushed
the
cdh_deltastreamer_sync
branch
from
86dfe6f to
efedb63
Compare
Contributor
Author
|
@n3nash: Ready for review. |
vinothchandar
approved these changes
Feb 7, 2019
Member
vinothchandar
left a comment
vinothchandar
left a comment
There was a problem hiding this comment.
okay makes sense. you just moved all the dependencies bundled from the profiles, directly into the pom..
| <artifactId>commons-configuration2</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> |
Member
There was a problem hiding this comment.
the hive.version we use would be compatible with the spark's bundled hive? even without shading?
Contributor
Author
There was a problem hiding this comment.
Without shading, there is compatibility issue with spark's bundled hive. So, clients need to use hoodie-spark-bundle (instead of hoodie-spark).
Member
There was a problem hiding this comment.
This is to even use the DataSource api? Lets chat once f2f
Contributor
Author
|
@n3nash @vinothchandar : Can one of you merge this if this looks ok. |
Contributor
|
LGTM, I can merge this @vinothchandar |
n3nash
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : Hoodie Utilities bundle does not include (and shade) hive jars unlike hoodie spark bundle. I have made changes to fix that.
I have also removed the profile settings and added doc to show users how to compile against hadoop/hive versions that is used in their deployments. This turns out to be more reliable than making Apache Hive-1.1.1 client work in CDH runtime environment. By removing the profile settings, there is no reference of CDH in Hoodie mvn code.
Testing:
Hoodie supports 3 types of environment (Apache Hive 2.x, Apache Hive 1.x, CDH Hive ). The maven profile settings change affects only the CDH version. I have tested hive sync against CDH environment.
We are also currently testing Deltastreamer against CDH environment to ensure they work end to end.