Skip to content

Conversation

@alexeykudinkin
Copy link
Contributor

@alexeykudinkin alexeykudinkin commented Apr 18, 2022

Tips

What is the purpose of the pull request

Spark unfortunately predicates some of its optimization Rules (and some other handling) on usage of HadoopFsRelation which leads to those optimizations not being applied when we rely on our custom Relation impls.

To work this around for the 0.11, we fallback to HadoopFsRelation in cases when it's feasible to do so.

NOTE: We're partially restoring logic present in 0.10.1

Brief change log

  • Adding toHadoopFsRelation method for BaseFileOnlyRelation
  • Fallback to HadoopFsRelation for non-Schema Evolution use-cases

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan nsivabalan added the priority:blocker Production down; release blocker label Apr 18, 2022
Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one clarification. looks good to me.

@vinothchandar
Copy link
Member

@xiarixiaoyao Can you please skim this PR as well

…nstead pass the config as param (which would be passed along to fork individual Hadoop conf)
@xiarixiaoyao
Copy link
Contributor

xiarixiaoyao commented Apr 19, 2022

@alexeykudinkin
if we support prune nest schema, can we avoid this performance problem
now schema evolution support prune nest schema, maybe we can use that prune function.
LGTM

@alexeykudinkin
Copy link
Contributor Author

@xiarixiaoyao it will most likely solve this particular issue, but we'll continue to be exposed to this becoming a problem again until we upstream the real fix and make HadoopFsRelation extensible in Spark

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xushiyan xushiyan merged commit 81bf771 into apache:master Apr 19, 2022
@xushiyan xushiyan deleted the ak/spk-ds-cow-fix branch April 19, 2022 17:40
xushiyan added a commit that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants