fallback to HadoopFsRelation #5343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
force-pushed
the
fallback-HadoopFsRel
branch
from
0354fcb to
300c4f0
Compare
| case HoodieFileFormat.PARQUET => new ParquetFileFormat | ||
| case HoodieFileFormat.ORC => new OrcFileFormat | ||
| }, | ||
| optParams)(sparkSession) |
Contributor
There was a problem hiding this comment.
maybe we need HoodieFileIndex or HoodieROTablePathFilter to filter old parquet file.
how about fallabck to the implement of 0.10.0
| val tableType = metaClient.getTableType | ||
| val queryType = parameters(QUERY_TYPE.key) | ||
| val enableSchemaOnRead = parameters.getOrElse(SCHEMA_EVOLUTION_ENABLE.key, SCHEMA_EVOLUTION_ENABLE.defaultValue.toString).toBoolean | ||
| val userSchema = if (schema == null) Option.empty[StructType] else Some(schema) |
Contributor
There was a problem hiding this comment.
maybe it better to use follow code.
val enableSchemaOnRead: Boolean = try {
!(new TableSchemaResolver(metaClient).getTableInternalSchemaFromCommitMetadata.orElse(InternalSchema.getEmptyInternalSchema)).isEmptySchema
} catch {
case _: Exception => false
}
Collaborator
Member
Author
|
close in favor of #5352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If schema on read is not enabled, use
HadoopFsRelation.BaseFileOnlyRelation is not able to read nested field; it reads the whole struct field like
ReadSchema: struct<repo:struct<id:bigint,name:string,url:string>>HadoopFsRelation reads
ReadSchema: struct<repo:struct<name:string>>