Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Mar 18, 2022

What is the purpose of the pull request

This PR removes the assert of FileStatus::getAccessTime which is flaky on rare occasions (the difference is in ms as shown below), since the access time can be changed when reading the file to get the file status for the expected and actual. This only affects testReadInlineFile().

[ERROR] org.apache.hudi.common.fs.inline.TestInLineFileSystem.testReadInlineFile
[ERROR]   Run 1: TestInLineFileSystem.testReadInlineFile:110->verifyFileStatus:372 expected: <1647752030224> but was: <1647752030244>
[ERROR]   Run 2: TestInLineFileSystem.testReadInlineFile:110->verifyFileStatus:372 expected: <1647752042953> but was: <1647752042973>
[ERROR]   Run 3: TestInLineFileSystem.testReadInlineFile:110->verifyFileStatus:372 expected: <1647752043009> but was: <1647752043029>
[ERROR]   Run 4: TestInLineFileSystem.testReadInlineFile:110->verifyFileStatus:372 expected: <1647752043061> but was: <1647752043081>

Brief change log

  • Removes flaky assert in TestInLineFileSystem.

Verify this pull request

This pull request is already covered by existing tests.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua mentioned this pull request Mar 19, 2022
5 tasks
@nsivabalan nsivabalan merged commit 15d1c18 into apache:master Mar 20, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants