Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Feb 28, 2022

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

codope and others added 11 commits February 24, 2022 21:04
Fix some unit tests

Resolve dependency issue

Upgrade Hadoop to 2.10.1 and fix HFile inline reader test

Separate hbase shaded version for presto bundle

Resolve hbase dep conflicts in flink, utilities and hadoop-mr bundles
Diasble access time validation
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@cuibo01
Copy link
Contributor

cuibo01 commented Mar 1, 2022

in hbase 2.x, scanner and reader add close method

@yihua
Copy link
Contributor Author

yihua commented Mar 10, 2022

in hbase 2.x, scanner and reader add close method

@cuibo01 Thanks for raising this. Do you mean that we should use the close() method to properly close the reader when done reading?

@nsivabalan
Copy link
Contributor

@yihua : can we close this one out if not valid

@yihua
Copy link
Contributor Author

yihua commented Mar 16, 2022

#5004 is ready for review for HBase upgrade. Closing this one which is for CI test and experiment only. @cuibo01 feel free to follow up with your suggestion there.

@yihua yihua closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants