Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Jan 25, 2022

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yihua yihua force-pushed the add-hudi-io-hbase-2.4.9 branch 3 times, most recently from 66b2381 to 6991ec6 Compare January 26, 2022 07:53
@yihua yihua force-pushed the add-hudi-io-hbase-2.4.9 branch from 6991ec6 to bd5b8ad Compare January 26, 2022 19:51
@yihua yihua force-pushed the add-hudi-io-hbase-2.4.9 branch from bd5b8ad to 4ca0251 Compare January 26, 2022 21:41
@yihua yihua force-pushed the add-hudi-io-hbase-2.4.9 branch from 4ca0251 to 13319b7 Compare January 27, 2022 07:00
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua
Copy link
Contributor Author

yihua commented Mar 16, 2022

This is another WIP PR based on #4695.

Per discussion, if we want to pull HFile related code into Hudi, there is more work to do to trim the code that's irrelevant, doing code rewrite inside classes, beyond just pulling in necessary classes, to bring LoC much lower than 66K. This direction is much more involved.

For now, we'll go with the approach of upgrading HBase to 2.x and properly shading the dependencies, before we write our own file format for the same purpose. #5004 is ready for review for HBase upgrade to 2.x along this line. Closing this WIP PR.

@yihua yihua closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants