-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-3161][RFC-47] Add Call Produce Command for Spark SQL #4607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1 on the feature |
df9e591 to
8511d75
Compare
xushiyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XuQianJin-Stars thanks for the RFC. 2 main points to highlight
- it'd be helpful to see a complete end-to-end example to illustrate the features, in addition to describing the implementation logic
- any consideration on security? as it's vulnerable to attacks like SQL injection, there better be some logic to mitigate this sort of vulnerabilities. would be helpful to highlight it here
Here are two concrete usage examples. Line 82 in 44f5262
|
xushiyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c545068 to
4bc4d43
Compare
|
hi @vinothchandar Do you have time to look at this PR? |
vinothchandar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this feature. it's super useful to get all CLI commands wrapped up here from the convenience of the spark shell.
I'll let @xushiyan drive this forward.
Tips
What is the purpose of the pull request
As shown in the figure above, The execution process of Call Command consists of two parts, SQL Parser and Procedure Run.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.