Skip to content

Conversation

@XuQianJin-Stars
Copy link
Contributor

@XuQianJin-Stars XuQianJin-Stars commented Jan 15, 2022

Tips

What is the purpose of the pull request

process
As shown in the figure above, The execution process of Call Command consists of two parts, SQL Parser and Procedure Run.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@xushiyan xushiyan added the rfc Request for comments label Jan 17, 2022
@nsivabalan
Copy link
Contributor

+1 on the feature

@XuQianJin-Stars XuQianJin-Stars changed the title [HUDI-3161][RFC-46] Add Call Produce Command for Spark SQL [HUDI-3161][RFC-47] Add Call Produce Command for Spark SQL Feb 4, 2022
Copy link
Member

@xushiyan xushiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuQianJin-Stars thanks for the RFC. 2 main points to highlight

  • it'd be helpful to see a complete end-to-end example to illustrate the features, in addition to describing the implementation logic
  • any consideration on security? as it's vulnerable to attacks like SQL injection, there better be some logic to mitigate this sort of vulnerabilities. would be helpful to highlight it here

@XuQianJin-Stars
Copy link
Contributor Author

@XuQianJin-Stars thanks for the RFC. 2 main points to highlight

  • it'd be helpful to see a complete end-to-end example to illustrate the features, in addition to describing the implementation logic
  • any consideration on security? as it's vulnerable to attacks like SQL injection, there better be some logic to mitigate this sort of vulnerabilities. would be helpful to highlight it here

Here are two concrete usage examples.

val commits = spark.sql(s"""call show_commits_metadata(table => '$tableName', limit => 10)""").collect()

Copy link
Member

@xushiyan xushiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@XuQianJin-Stars
Copy link
Contributor Author

hi @vinothchandar Do you have time to look at this PR?

Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this feature. it's super useful to get all CLI commands wrapped up here from the convenience of the spark shell.

I'll let @xushiyan drive this forward.

@xushiyan xushiyan merged commit 6faed3d into apache:master Mar 4, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfc Request for comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants