Skip to content

Conversation

@pengzhiwei2018
Copy link

What is the purpose of the pull request

Support clustering command for spark sql.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@vinothchandar vinothchandar self-assigned this Sep 7, 2021
@vinothchandar vinothchandar added the area:sql SQL interfaces label Sep 23, 2021
@nsivabalan
Copy link
Contributor

@yihua : Can you take a stab at reviewing this patch. If you wanna jam or need some headsup, I can fill you in.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Nov 5, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua self-assigned this Dec 13, 2021
@yihua
Copy link
Contributor

yihua commented Jan 9, 2022

@pengzhiwei2018 Could you rebase the PR on latest master to resolve the conflicts?

@YannByron
Copy link
Contributor

@nsivabalan @yihua
If no one take this up, i am glad to.

@yihua
Copy link
Contributor

yihua commented Jan 10, 2022

@nsivabalan @yihua If no one take this up, i am glad to.

@YannByron Feel free to take a stab at this PR.

@YannByron
Copy link
Contributor

@nsivabalan @yihua
I cherry-pick @pengzhiwei2018 codes, and submit another pr: #4613 .

@pengzhiwei2018
Copy link
Author

pengzhiwei2018 commented Feb 5, 2022

@pengzhiwei2018 Could you rebase the PR on latest master to resolve the conflicts?

Hi @yihua @nsivabalan , Sorry for the late reply. I have noticed that @XuQianJin-Stars have proposed the [RFC-47] Add Call Produce Command for Spark SQL(#4607), which will be a more generic way to support the hudi cli command. This Pr can be a part of the RFC-47 so that we can unified the grammar for all the commands including the clustering command. So I think @XuQianJin-Stars can you take a look at the Pr and think the common way to support the hudi cli command.

@XuQianJin-Stars
Copy link
Contributor

Call Produce Command for Spark SQL

hudi cli command can indeed be achieved through Call Produce Command.

@nsivabalan
Copy link
Contributor

sounds good with me if you are fine. I was wondering if patch is already ready, why close it out. but agree that call produce might be the way to go. we can probably close this patch then. and let @XuQianJin-Stars put up a patch for clustering w/ call produce.

@nsivabalan nsivabalan closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:sql SQL interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants