Skip to content

[HUDI-3148] Create pushgateway client based on port #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsivabalan merged 2 commits into from
Jan 10, 2022
Merged

[HUDI-3148] Create pushgateway client based on port #4497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80313d4
[MINOR] Create pushgateway client based on port
Jan 3, 2022
7e57a13
Fixing https address
nsivabalan Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...t-common/src/main/java/org/apache/hudi/metrics/prometheus/PushGatewayMetricsReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ public PushGatewayMetricsReporter(HoodieWriteConfig config, MetricRegistry regis
TimeUnit.SECONDS,
TimeUnit.SECONDS,
getJobName(),
serverHost + ":" + serverPort,
serverHost,
serverPort,
deleteShutdown);
}

Expand Down
19 changes: 17 additions & 2 deletions ...i-client-common/src/main/java/org/apache/hudi/metrics/prometheus/PushGatewayReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
import io.prometheus.client.CollectorRegistry;
import io.prometheus.client.dropwizard.DropwizardExports;
import io.prometheus.client.exporter.PushGateway;
import java.net.MalformedURLException;
import java.net.URL;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;

Expand All @@ -51,17 +53,30 @@ protected PushGatewayReporter(MetricRegistry registry,
TimeUnit rateUnit,
TimeUnit durationUnit,
String jobName,
String address,
String serverHost,
int serverPort,
boolean deleteShutdown) {
super(registry, "hudi-push-gateway-reporter", filter, rateUnit, durationUnit);
this.jobName = jobName;
this.deleteShutdown = deleteShutdown;
collectorRegistry = new CollectorRegistry();
metricExports = new DropwizardExports(registry);
pushGateway = new PushGateway(address);
pushGateway = createPushGatewayClient(serverHost, serverPort);
metricExports.register(collectorRegistry);
}

private PushGateway createPushGatewayClient(String serverHost, int serverPort) {
if (serverPort == 443) {
try {
return new PushGateway(new URL("https://" + serverHost + ":" + serverPort));
} catch (MalformedURLException e) {
e.printStackTrace();
throw new IllegalArgumentException("Malformed pushgateway host: " + serverHost);
}
}
return new PushGateway(serverHost + ":" + serverPort);
}

@Override
public void report(SortedMap<String, Gauge> gauges,
SortedMap<String, Counter> counters,
Expand Down