[HUDI-3148] Create pushgateway client based on port#4497
Merged
nsivabalan merged 2 commits intoapache:masterfrom Jan 10, 2022
Merged
[HUDI-3148] Create pushgateway client based on port#4497nsivabalan merged 2 commits intoapache:masterfrom
nsivabalan merged 2 commits intoapache:masterfrom
Conversation
nsivabalan
changed the title
nsivabalan
added
priority:high
nsivabalan
reviewed
Jan 6, 2022
| private PushGateway createPushGatewayClient(String serverHost, int serverPort) { | ||
| if (serverPort == 443) { | ||
| try { | ||
| return new PushGateway(new URL("https://" + serverHost)); |
Contributor
There was a problem hiding this comment.
@t0il3ts0ap : Did you test this patch?
don't we need
new URL("https://" + serverHost + ":" + serverPort));
Contributor
Author
There was a problem hiding this comment.
@nsivabalan Srry, couldnt reply in time. Yes this is tested, its not needed. Shouldn't be an issue, even if added.
nsivabalan
reviewed
Jan 6, 2022
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
One small clarification. Can land once clarified.
nsivabalan
changed the title
nsivabalan
approved these changes
Jan 10, 2022
Collaborator
Contributor
|
@t0il3ts0ap : sorry do you know if suffixing the port would work or fail? I did not get a chance to test it out, but suffixed the port and merged it in. |
5 tasks
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
Co-authored-by: anoop narang <anoop.narang@navi.com> Co-authored-by: sivabalan narayanan <n.siva.b@gmail.com>
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
Co-authored-by: anoop narang <anoop.narang@navi.com> Co-authored-by: sivabalan narayanan <n.siva.b@gmail.com>
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
Co-authored-by: anoop narang <anoop.narang@navi.com> Co-authored-by: sivabalan narayanan <n.siva.b@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
#4496
Fix above issue
Brief change log
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.