[HUDI-3094] Unify Hive's InputFormat implementations to avoid duplication#4417
Merged
yihua merged 9 commits intoapache:masterfrom Jan 11, 2022
Merged
[HUDI-3094] Unify Hive's InputFormat implementations to avoid duplication#4417yihua merged 9 commits intoapache:masterfrom
yihua merged 9 commits intoapache:masterfrom
Conversation
alexeykudinkin
changed the title
added 6 commits
January 5, 2022 14:40
…ting FS for to be shared across File-format specific implementations - Snapshot queries - Incremental queries
Killing dead-code
alexeykudinkin
changed the title
alexeykudinkin
force-pushed
the
ak/rpath-ref-1
branch
from
0e81843 to
27f2870
Compare
…en in the super-class by introducing standalone non-overridable `doListStatus` proxying to `FileInputFormat.listStatus`
yihua
reviewed
Jan 11, 2022
Contributor
yihua
left a comment
yihua
left a comment
There was a problem hiding this comment.
Overall LGTM. I put up a couple of clarification questions.
| import java.util.Map; | ||
|
|
||
| /** | ||
| * TODO java-doc |
Contributor
There was a problem hiding this comment.
nit: docs can be put in now :)
added 2 commits
January 11, 2022 10:58
yihua
approved these changes
Jan 11, 2022
Contributor
Author
|
@hudi-bot run azure |
Member
vinothchandar
left a comment
vinothchandar
left a comment
There was a problem hiding this comment.
Can you confirm that there are no actual code changes beyond consolidating into hierarchies here?
| @UseRecordReaderFromInputFormat | ||
| @UseFileSplitsFromInputFormat | ||
| public class HoodieParquetInputFormat extends MapredParquetInputFormat implements Configurable { | ||
| public class HoodieParquetInputFormat extends HoodieFileInputFormatBase implements Configurable { |
Member
There was a problem hiding this comment.
this is a problem. Hive code special cases subclasses of MapredParquetInputFormat for some of the optimizations. So we need to maintain this hierarchy.
Member
There was a problem hiding this comment.
Contributor
Author
|
@vinothchandar correct, it mostly moves code around to avoid duplication |
5 tasks
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Unify Hive's
FileInputFormatimplementations to avoid unnecessary duplicationBrief change log
HoodieFileInputFormatBaseHoodieFileInputFormatBaseVerify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.