[HUDI-8771] Fix Incorrect classification of input paths in InputPathHandler and HoodieInputFormatUtils#12495
Merged
wombatu-kun merged 1 commit intoapache:masterfrom Dec 18, 2024
Conversation
skyshineb
force-pushed
the
hudi-8771-Incorrect-classification-of-input-paths-in-InputPathHandler
branch
from
e62aa6e to
35fc0a7
Compare
github-actions
Bot
added
size:S
wombatu-kun
reviewed
Dec 17, 2024
| Option<HoodieTableMetaClient> matchedMetaClient = Option.fromJavaOptional(metaClientList.stream() | ||
| .filter(metaClient -> { | ||
| String basePathStr = metaClient.getBasePath().toString(); | ||
| return inputPathStr.equals(basePathStr) || inputPathStr.startsWith(basePathStr + "/"); }) |
Contributor
There was a problem hiding this comment.
Shouldn't we do the same fix for checks in groupFileStatusForSnapshotPaths (461 and 463 lines)?
Contributor
Author
There was a problem hiding this comment.
The groupFileStatusForSnapshotPaths is not used anywhere. In the HUDI-3094 the HoodieParquetInputFormat.listStatus() which was the caller of this method was removed and related logic was moved to InputPathHandler where it belongs now. So I deleted this method entirely.
skyshineb
force-pushed
the
hudi-8771-Incorrect-classification-of-input-paths-in-InputPathHandler
branch
from
35fc0a7 to
e5de599
Compare
…andler and HoodieInputFormatUtils
skyshineb
force-pushed
the
hudi-8771-Incorrect-classification-of-input-paths-in-InputPathHandler
branch
from
e5de599 to
402ecde
Compare
Contributor
|
@hudi-bot run azure |
wombatu-kun
approved these changes
Dec 18, 2024
skyshineb
deleted the
hudi-8771-Incorrect-classification-of-input-paths-in-InputPathHandler
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
InputPathHandlerandHoodieInputFormatUtilsHoodieInputFormatUtils.groupSnapshotPathsByMetaClient()was not strict enough and allowed multiple ownership of paths.forEach()usage could potentially make multiplemetaClientassociations for a single path.HoodieInputFormatUtils.groupFileStatusForSnapshotPaths()since the logic that called this method were refactored in HUDI-3094 and this responsibility moved toInputPathHandlerImpact
Reduce ambiguity of input paths classification
Risk level (write none, low medium or high below)
Low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist