Skip to content

[HUDI-9571] Avoid scanning timeline to fetch InternalSchema for schema evolution #13525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Jul 9, 2025
Merged

[HUDI-9571] Avoid scanning timeline to fetch InternalSchema for schema evolution #13525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 3 additions & 21 deletions hudi-common/src/main/java/org/apache/hudi/common/util/InternalSchemaCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,15 @@ public class InternalSchemaCache {

/**
* Search internalSchema based on versionID.
* first step: try to get internalSchema from hoodie commit files, we no need to add lock.
* if we cannot get internalSchema by first step, then we try to get internalSchema from cache.
*
* <p>The internalSchema is fetched from cache or history schema file directly, and should not
* be fetched from commit meta file since the overhead of scanning timeline is higher.
*
* @param versionID schema version_id need to search
* @param metaClient current hoodie metaClient
* @return internalSchema
*/
public static InternalSchema searchSchemaAndCache(long versionID, HoodieTableMetaClient metaClient) {
Option<InternalSchema> candidateSchema = getSchemaByReadingCommitFile(versionID, metaClient);
if (candidateSchema.isPresent()) {
return candidateSchema.get();
}
String tablePath = metaClient.getBasePath().toString();
// use segment lock to reduce competition.
synchronized (LOCK_LIST[tablePath.hashCode() & (LOCK_LIST.length - 1)]) {
Expand Down Expand Up @@ -119,21 +116,6 @@ private static TreeMap<Long, InternalSchema> getHistoricalSchemas(HoodieTableMet
return result;
}

private static Option<InternalSchema> getSchemaByReadingCommitFile(long versionID, HoodieTableMetaClient metaClient) {
try {
HoodieTimeline timeline = metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants();
List<HoodieInstant> instants = timeline.getInstantsAsStream().filter(f -> f.requestedTime().equals(String.valueOf(versionID))).collect(Collectors.toList());
if (instants.isEmpty()) {
return Option.empty();
}
HoodieCommitMetadata metadata = timeline.readCommitMetadata(instants.get(0));
String latestInternalSchemaStr = metadata.getMetadata(SerDeHelper.LATEST_SCHEMA);
return SerDeHelper.fromJson(latestInternalSchemaStr);
} catch (Exception e) {
throw new HoodieException("Failed to read schema from commit metadata", e);
}
}

/**
* Get internalSchema and avroSchema for compaction/cluster operation.
*
Expand Down
Loading