Skip to content

Conversation

@cshuo
Copy link
Collaborator

@cshuo cshuo commented Jul 7, 2025

Change Logs

Avoid scanning timeline to fetch InternalSchema for schema evolution

Impact

Improve performance for getting InternalSchema for schema evolution.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@cshuo cshuo marked this pull request as draft July 7, 2025 03:47
@cshuo cshuo force-pushed the schema_evolve_test branch from 2997c3f to 870c7ca Compare July 7, 2025 03:49
@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Jul 7, 2025
@cshuo cshuo force-pushed the schema_evolve_test branch from 870c7ca to 731197b Compare July 8, 2025 08:25
@cshuo cshuo changed the title [DNM] Always get internal schema from history schema file [HUDI-9571] Avoid scanning timeline to fetch InternalSchema for schema evolution Jul 8, 2025
@cshuo cshuo marked this pull request as ready for review July 8, 2025 08:26
@hudi-bot
Copy link
Collaborator

hudi-bot commented Jul 8, 2025

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@cshuo
Copy link
Collaborator Author

cshuo commented Jul 9, 2025

cc @xiarixiaoyao plz take a look if you have time.

@danny0405 danny0405 merged commit aa3dcd8 into apache:master Jul 9, 2025
175 of 184 checks passed
@danny0405
Copy link
Contributor

@xiarixiaoyao I landed it first because the change is striaght-forward, can you double check this change?

@xiarixiaoyao
Copy link
Contributor

xiarixiaoyao commented Jul 9, 2025

@cshuo This modification is acceptable.
One small suggestion: Currently, we're placing historical schemas in .schema dir because we're concerned about the schema information becoming too large.
but In practice, our production environment doesn't involve frequent schema changes. Could we consider storing historical schema information directly in the commit files just like iceberg? This would significantly simply the logical of retrieving the schema information.

@danny0405
Copy link
Contributor

Could we consider storing historical schema information directly in the commit files just like iceberg?

I think we can after we bring in new schema abstractions, part of RFC-88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants