Skip to content

Conversation

@jonvex
Copy link
Contributor

@jonvex jonvex commented May 7, 2024

Change Logs

need #11163 to land first
Restructure HFileBootstrapIndex to separate Hadoop-dependent logic

hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java
is split up into:
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndex.java
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexReader.java
hudi-hadoop-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HBaseHFileBootstrapIndexReader.java
hudi-hadoop-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HBaseHFileBootstrapIndexWriter.java
and hudi-hadoop-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java

Also moved SeekableByteArrayInputStream from
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroHFileReaderImplBase.java
to hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHFileUtils.java

Impact

removing hadoop dep from hudi common

Risk level (write none, low medium or high below)

low

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@jonvex jonvex requested a review from yihua May 10, 2024 02:49
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apache apache deleted a comment from hudi-bot May 10, 2024
@yihua
Copy link
Contributor

yihua commented May 10, 2024

Azure CI is green.
Screenshot 2024-05-09 at 22 14 34

@yihua yihua merged commit b149606 into apache:master May 10, 2024
yihua pushed a commit that referenced this pull request May 15, 2024
yihua pushed a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL PR with lines of changes > 1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants