-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-7725] Restructure HFileBootstrapIndex to separate Hadoop-dependent logic #11171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yihua
merged 68 commits into
apache:master
from
jonvex:hfile_bootstrap_index_remove_hadoop
May 10, 2024
Merged
[HUDI-7725] Restructure HFileBootstrapIndex to separate Hadoop-dependent logic #11171
yihua
merged 68 commits into
apache:master
from
jonvex:hfile_bootstrap_index_remove_hadoop
May 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Utils#getFSDataInputStream part
yihua
reviewed
May 10, 2024
hudi-cli/src/main/java/org/apache/hudi/cli/commands/BootstrapCommand.java
Outdated
Show resolved
Hide resolved
yihua
reviewed
May 10, 2024
...-hadoop-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieAvroFileReaderFactory.java
Show resolved
Hide resolved
yihua
approved these changes
May 10, 2024
Contributor
yihua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…ent logic (#11171) Co-authored-by: Jonathan Vexler <=>
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…ent logic (#11171) Co-authored-by: Jonathan Vexler <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Change Logs
need #11163 to land first
Restructure HFileBootstrapIndex to separate Hadoop-dependent logic
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java
is split up into:
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndex.java
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexReader.java
hudi-hadoop-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HBaseHFileBootstrapIndexReader.java
hudi-hadoop-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HBaseHFileBootstrapIndexWriter.java
and hudi-hadoop-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java
Also moved SeekableByteArrayInputStream from
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroHFileReaderImplBase.java
to hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHFileUtils.java
Impact
removing hadoop dep from hudi common
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist