[HUDI-7350] Make Hudi reader and writer factory APIs Hadoop-independent #11163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
May 1, 2024 13:19
…Utils#getFSDataInputStream part
added 6 commits
May 6, 2024 17:25
added 9 commits
May 9, 2024 10:04
github-actions
bot
added
size:L
jonvex
force-pushed
the
create_hudi_io_factory
branch
from
1a3d7a8 to
5bf8143
Compare
github-actions
bot
added
size:XL
github-actions
bot
added
size:L
yihua
reviewed
May 9, 2024
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieParquetDataBlock.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileReader.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieFileReaderFactory.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieFileWriterFactory.java
Outdated
Show resolved
Hide resolved
hudi-common/src/test/java/org/apache/hudi/common/testutils/reader/HoodieTestReaderContext.java
Outdated
Show resolved
Hide resolved
yihua
reviewed
May 9, 2024
...doop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieAvroFileReaderFactory.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieBaseParquetWriter.java
Outdated
Show resolved
Hide resolved
yihua
reviewed
May 9, 2024
| baseInstantTime, | ||
| new LocalTaskContextSupplier(), | ||
| true)) { | ||
| HoodieConfig cfg = new HoodieConfig(); |
Contributor
There was a problem hiding this comment.
Should this test class be moved to hudi-hadoop-common module? HoodieAvroWriteSupport<IndexedRecord> needs to be tested.
Contributor
Author
There was a problem hiding this comment.
not sure what you are suggesting here
Contributor
There was a problem hiding this comment.
Basically, making sure that the bloom filter writing is tested with HoodieAvroWriteSupport.
Contributor
Author
There was a problem hiding this comment.
Ran a test with the debugger and this shows that bloom filter is used
yihua
reviewed
May 9, 2024
Contributor
yihua
left a comment
yihua
left a comment
There was a problem hiding this comment.
Also, rename the PR to "Make Hudi reader and writer factory APIs Hadoop-independent"?
jonvex
changed the title
Contributor
Author
|
passed ci: |
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…nt (#11163) Abstract io reader and writer to de-hadoop --------- Co-authored-by: Jonathan Vexler <=>
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…nt (#11163) Abstract io reader and writer to de-hadoop --------- Co-authored-by: Jonathan Vexler <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Abstract io reader and writer to de-hadoop
Impact
de-hadooping for trino
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist