Skip to content

HBASE-23171 Ensure region state error messages include server making report (branch-2.1) #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busbey merged 1 commit into from
Oct 30, 2019
Merged

HBASE-23171 Ensure region state error messages include server making report (branch-2.1) #777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,8 +991,8 @@ void checkOnlineRegionsReportForMeta(final ServerName serverName, final Set<byte
final RegionInfo hri = getMetaRegionFromName(regionName);
if (hri == null) {
if (LOG.isTraceEnabled()) {
LOG.trace("Skip online report for region=" + Bytes.toStringBinary(regionName) +
" while meta is loading");
LOG.trace("Skip online report for region={} while meta is loading from server={}",
Copy link
Contributor

@saintstack saintstack Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

region= is redundant.

Copy link
Contributor

@saintstack saintstack Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is server= ... smile. Who else would be making a report here.

Copy link
Contributor Author

@busbey busbey Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would the server making the report be redundant?

Copy link
Contributor Author

@busbey busbey Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If regionName is redundant then why does getMetaRegionFromName take it as an argument?

Bytes.toStringBinary(regionName), serverName);
}
continue;
}
Expand Down Expand Up @@ -1035,7 +1035,8 @@ void checkOnlineRegionsReport(final ServerStateNode serverNode, final Set<byte[]
" but state has otherwise AND NO procedure is running");
}
} catch (UnexpectedStateException e) {
LOG.warn(regionNode.toString() + " reported unexpteced OPEN: " + e.getMessage(), e);
LOG.warn("{} reported unexpteced OPEN: {} sever={}", regionNode.toString(),
Copy link
Contributor

@saintstack saintstack Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

e.getMessage(), serverName, e);
}
}
} else if (!regionNode.isInState(State.CLOSING, State.SPLITTING)) {
Expand All @@ -1054,7 +1055,8 @@ void checkOnlineRegionsReport(final ServerStateNode serverNode, final Set<byte[]
//See HBASE-21421, we can count on reportRegionStateTransition calls
//We only log a warming here. It could be a network lag.
LOG.warn("Failed to checkOnlineRegionsReport, maybe due to network lag, "
+ "if this message continues, be careful of double assign", e);
+ "if this message continues, be careful of double assign. report from server={}",
serverName, e);
}
}

Expand Down