HBASE-23171 Ensure region state error messages include server making report (branch-2.1) #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…report (branch-2.1)
Contributor
|
+1 |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
thanks for the review! |
saintstack
reviewed
Oct 31, 2019
| if (LOG.isTraceEnabled()) { | ||
| LOG.trace("Skip online report for region=" + Bytes.toStringBinary(regionName) + | ||
| " while meta is loading"); | ||
| LOG.trace("Skip online report for region={} while meta is loading from server={}", |
Contributor
There was a problem hiding this comment.
So is server= ... smile. Who else would be making a report here.
Contributor
Author
There was a problem hiding this comment.
Why would the server making the report be redundant?
Contributor
Author
There was a problem hiding this comment.
If regionName is redundant then why does getMetaRegionFromName take it as an argument?
| } | ||
| } catch (UnexpectedStateException e) { | ||
| LOG.warn(regionNode.toString() + " reported unexpteced OPEN: " + e.getMessage(), e); | ||
| LOG.warn("{} reported unexpteced OPEN: {} sever={}", regionNode.toString(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.