HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master(#6994) #6998

Umeshkumar9414 · 2025-05-19T07:52:46Z

HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master(#6994)

…ster (apache#6994) Co-authored-by: ukumawat <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]>

NihalJain · 2025-05-19T16:34:14Z

hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterQosFunction.java

+      splitWalProcedureDoneReport);
+    checkMethod(conf, "GetLastFlushedSequenceId", HConstants.HIGH_QOS, qosFunction,
+      lastFlushedSequenceIdRequest);
+    checkMethod(conf, "RegionServerReport", HConstants.HIGH_QOS, qosFunction,


also add corresponding test for checkMethod(conf, "CompactRegion", HConstants.ADMIN_QOS, qosFunction);?

won't it make difference in branch-3 and branch-2 ?
While writing I didn't find a good way to add Test for all so just added for some important one.

I guess the point is previous line 101 has checkMethod(conf, "CompactRegion", HConstants.ADMIN_QOS, qosFunction); and that check would still be valid in branch-2, so you don't need to remove that line here.

Ultimately, I'm not sure how important it is, though, since the method is removed in master branch as part of #3612 (d26bcaa and https://issues.apache.org/jira/browse/HBASE-25288)... and it's probably unnecessarily ADMIN_QOS here in branch-2.

added this as well.

I'm not sure why you didn't just leave it inside the testAnnotations method :)

NihalJain · 2025-05-19T16:35:01Z

LGTM, will merge tomorrow morning IST and pull back upto branch-2.6! Thanks @Umeshkumar9414 !

d-c-manning · 2025-05-20T05:28:28Z

hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterQosFunction.java

+      splitWalProcedureDoneReport);
+    checkMethod(conf, "GetLastFlushedSequenceId", HConstants.HIGH_QOS, qosFunction,
+      lastFlushedSequenceIdRequest);
+    checkMethod(conf, "RegionServerReport", HConstants.HIGH_QOS, qosFunction,


I guess the point is previous line 101 has checkMethod(conf, "CompactRegion", HConstants.ADMIN_QOS, qosFunction); and that check would still be valid in branch-2, so you don't need to remove that line here.

Ultimately, I'm not sure how important it is, though, since the method is removed in master branch as part of #3612 (d26bcaa and https://issues.apache.org/jira/browse/HBASE-25288)... and it's probably unnecessarily ADMIN_QOS here in branch-2.

…ASE-29323_branch2

Apache-HBase · 2025-05-20T13:10:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	9m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+1 💚	mvninstall	8m 9s		branch-2 passed
+1 💚	compile	7m 6s		branch-2 passed
+1 💚	checkstyle	1m 20s		branch-2 passed
+1 💚	spotbugs	2m 46s		branch-2 passed
-1 ❌	spotless	1m 28s		branch has 1 errors when running spotless:check, run spotless:apply to fix.
			_ Patch Compile Tests _
+1 💚	mvninstall	7m 36s		the patch passed
+1 💚	compile	4m 2s		the patch passed
+1 💚	javac	4m 2s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 59s		the patch passed
+1 💚	spotbugs	2m 21s		the patch passed
+1 💚	hadoopcheck	41m 12s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
-1 ❌	spotless	1m 19s		patch has 1 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 27s		The patch does not generate ASF License warnings.
		92m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6998
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 0f668dedceda 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0d4934d`
Default Java	Eclipse Adoptium-11.0.23+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/artifact/yetus-general-check/output/branch-spotless.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-20T13:11:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	11m 30s		Docker mode activated.
-0 ⚠️	yetus	0m 13s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	5m 21s		branch-2 passed
+1 💚	compile	3m 6s		branch-2 passed
+1 💚	javadoc	0m 49s		branch-2 passed
+1 💚	shadedjars	8m 27s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	5m 52s		the patch passed
+1 💚	compile	1m 41s		the patch passed
+1 💚	javac	1m 41s		the patch passed
+1 💚	javadoc	0m 48s		the patch passed
+1 💚	shadedjars	8m 34s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	24m 32s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		73m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6998
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 7c6780e320a3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0d4934d`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/testReport/
Max. process+thread count	1868 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-20T16:01:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 35s		branch-2 passed
+1 💚	compile	0m 41s		branch-2 passed
+1 💚	javadoc	0m 25s		branch-2 passed
+1 💚	shadedjars	5m 18s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 26s		the patch passed
+1 💚	compile	0m 41s		the patch passed
+1 💚	javac	0m 41s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed
+1 💚	shadedjars	5m 17s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	228m 47s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		251m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6998
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux f5ff37f88446 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0d4934d`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/testReport/
Max. process+thread count	4143 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-20T16:02:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 24s		branch-2 passed
+1 💚	compile	0m 50s		branch-2 passed
+1 💚	javadoc	0m 26s		branch-2 passed
+1 💚	shadedjars	6m 28s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	compile	0m 50s		the patch passed
+1 💚	javac	0m 50s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
+1 💚	shadedjars	6m 23s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	222m 9s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		249m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6998
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c8b897488c9f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0d4934d`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/testReport/
Max. process+thread count	4457 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6998/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Umeshkumar9414 · 2025-05-20T16:28:57Z

These failures caused by " Job manager has been shut down." @NihalJain last run was successful, after that I added that sigle test and that was running fine on local. Can you rerun the build and help me with this PR?

NihalJain · 2025-05-20T16:40:33Z

These failures caused by " Job manager has been shut down." @NihalJain last run was successful, after that I added that sigle test and that was running fine on local. Can you rerun the build and help me with this PR?

I think we are fine as your last commit should not cause the failure. Let me merge this!

…ster(#6994) (#6998) Co-authored-by: ukumawat <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]> (cherry picked from commit 19440ac)

…ster(apache#6994) (apache#6998) Co-authored-by: ukumawat <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]> (cherry picked from commit d187378)

This comment has been minimized.

Sign in to view

Umeshkumar9414 mentioned this pull request May 19, 2025

HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master #6994

Merged

This comment has been minimized.

Sign in to view

mnpoonia approved these changes May 19, 2025

View reviewed changes

NihalJain reviewed May 19, 2025

View reviewed changes

NihalJain approved these changes May 19, 2025

View reviewed changes

d-c-manning approved these changes May 20, 2025

View reviewed changes

ukumawat added 2 commits May 20, 2025 16:11

Merge remote-tracking branch 'refs/remotes/upstream/branch-2' into HB…

2071e39

…ASE-29323_branch2

HBASE-29323 added test for CompactRegion as well

0d4934d

NihalJain merged commit 19440ac into apache:branch-2 May 20, 2025
1 check failed

HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master(#6994) #6998

HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master(#6994) #6998

Uh oh!

Conversation

Umeshkumar9414 commented May 19, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NihalJain May 19, 2025

Choose a reason for hiding this comment

Uh oh!

Umeshkumar9414 May 20, 2025

Choose a reason for hiding this comment

Uh oh!

d-c-manning May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Umeshkumar9414 May 20, 2025

Choose a reason for hiding this comment

Uh oh!

d-c-manning May 20, 2025

Choose a reason for hiding this comment

Uh oh!

NihalJain commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

d-c-manning May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 20, 2025

Uh oh!

Apache-HBase commented May 20, 2025

Uh oh!

Apache-HBase commented May 20, 2025

Uh oh!

Apache-HBase commented May 20, 2025

Uh oh!

Umeshkumar9414 commented May 20, 2025

Uh oh!

NihalJain commented May 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NihalJain commented May 19, 2025 •

edited

Loading