HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master #6994

Umeshkumar9414 · 2025-05-16T12:34:52Z

These reports are critical for completing region movements and ensuring availability. Any delay in reporting can directly impact system availability.

…RegionStateTransition

virajjasani

+1

d-c-manning · 2025-05-16T23:50:20Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java

  }

  @Override
+  @QosPriority(priority = HConstants.HIGH_QOS)


why HIGH_QOS vs. ADMIN_QOS? Are they in conflict with each other? Does HIGH_QOS do something here that ADMIN_QOS does not? No other methods in this class use HIGH_QOS. And it seems SimpleRpcScheduler doesn't distinguish between the two.

In MasterAnnotationReadingPriorityFunction we are using HIGH_QOS for ReportRegionStateTransition rpc. Taking a example of that I used the same priority here as well.

And it seems SimpleRpcScheduler doesn't distinguish between the two.

Yeah, SimpleRpcScheduler doesn't distinguish between both, apart from META_TRANSITION_QOS, it just check if priority is greater that QOS_THRESHOLD(10).

Apache9 · 2025-05-17T02:34:23Z

I suggest we just change the code in MasterAnnotationReadingPriorityFunction, for all th methods defined in RegionServerStatusProtos, we give them higher QOS?

…E-29323

…onServerReportRequest

Umeshkumar9414 · 2025-05-17T12:52:04Z

I suggest we just change the code in MasterAnnotationReadingPriorityFunction, for all th methods defined in RegionServerStatusProtos, we give them higher QOS?

This would be good if in future we will be adding some new rpc methods. I have made the changes.
Just have one concern that MasterAnnotationReadingPriorityFunction seems little hidden and looking at MasterRpcServices one can't figure out the priority of these methods.

…tions

Apache-HBase · 2025-05-17T18:52:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 5s		master passed
+1 💚	compile	3m 13s		master passed
+1 💚	checkstyle	0m 37s		master passed
+1 💚	spotbugs	1m 31s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	compile	3m 11s		the patch passed
+1 💚	javac	3m 11s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 36s		the patch passed
+1 💚	spotbugs	1m 40s		the patch passed
+1 💚	hadoopcheck	11m 46s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 9s		The patch does not generate ASF License warnings.
		38m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6994/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6994
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 8df182f5881d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e48dc4a`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6994/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-17T22:28:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 16s		master passed
+1 💚	compile	0m 57s		master passed
+1 💚	javadoc	0m 31s		master passed
+1 💚	shadedjars	6m 0s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	0m 57s		the patch passed
+1 💚	javac	0m 57s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed
+1 💚	shadedjars	5m 53s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	227m 21s		hbase-server in the patch passed.
		254m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6994/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6994
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 7950e19fc457 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e48dc4a`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6994/5/testReport/
Max. process+thread count	5977 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6994/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-05-19T05:52:38Z

Hi @Umeshkumar9414 can you please check if the jira title is still relevant, please update if otherwise!

NihalJain · 2025-05-19T06:05:27Z

Hi @Umeshkumar9414 could you please raise a backport PR for branch-2 ?

…ster (#6994) Co-authored-by: ukumawat <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]> (cherry picked from commit d187378)

…ster (apache#6994) Co-authored-by: ukumawat <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]>

Umeshkumar9414 · 2025-05-19T09:12:42Z

Hi @Umeshkumar9414 could you please raise a backport PR for branch-2 ?

I have raised a PR - #6998

…ster(#6994) (#6998) Co-authored-by: ukumawat <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]> (cherry picked from commit d187378)

…ster(#6994) (#6998) Co-authored-by: ukumawat <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]> (cherry picked from commit 19440ac)

…ster(apache#6994) (apache#6998) Co-authored-by: ukumawat <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]> (cherry picked from commit d187378)

HBASE-29323 use ADMIN_QOS priority for reportProcedureDone and report…

65975f6

…RegionStateTransition

This comment has been minimized.

Sign in to view

Umeshkumar9414 closed this May 16, 2025

HBASE-29323 use HIGH_QOS priority for reportProcedureDone

bbf9f24

Umeshkumar9414 reopened this May 16, 2025

Umeshkumar9414 changed the title ~~HBASE-29323 Use Priority Handler for reportRegionStateTransition and reportProcedureDone at Master~~ HBASE-29323 Use Priority Handler for reportProcedureDone at Master May 16, 2025

This comment has been minimized.

Sign in to view

virajjasani approved these changes May 16, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

NihalJain approved these changes May 16, 2025

View reviewed changes

d-c-manning approved these changes May 16, 2025

View reviewed changes

mnpoonia approved these changes May 17, 2025

View reviewed changes

ukumawat added 2 commits May 17, 2025 17:10

Merge remote-tracking branch 'refs/remotes/upstream/master' into HBAS…

b0214f9

…E-29323

HBASE-29323 use HIGH_QOS priority for all param class defined in Regi…

0e7404e

…onServerReportRequest

This comment has been minimized.

Sign in to view

HBASE-29323 added JUnits and comment change

c1a2506

This comment has been minimized.

Sign in to view

HBASE-29323 Handling NPE if no enclosing class present

a8c338b

This comment has been minimized.

Sign in to view

HBASE-29323 resolve test failure for TestMasterQosFunction.testAnnota…

e48dc4a

…tions

This comment has been minimized.

Sign in to view

Apache9 approved these changes May 19, 2025

View reviewed changes

Umeshkumar9414 changed the title ~~HBASE-29323 Use Priority Handler for reportProcedureDone at Master~~ HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master May 19, 2025

NihalJain merged commit d187378 into apache:master May 19, 2025
1 check passed

Umeshkumar9414 mentioned this pull request May 19, 2025

HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master(#6994) #6998

Merged

HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master #6994

HBASE-29323 Use Priority Handler for all RegionServerStatus rpc at Master #6994

Uh oh!

Conversation

Umeshkumar9414 commented May 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

d-c-manning May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Umeshkumar9414 May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache9 commented May 17, 2025

Uh oh!

This comment has been minimized.

Umeshkumar9414 commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented May 17, 2025

Uh oh!

Apache-HBase commented May 17, 2025

Uh oh!

NihalJain commented May 19, 2025

Uh oh!

Uh oh!

NihalJain commented May 19, 2025

Uh oh!

Umeshkumar9414 commented May 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Umeshkumar9414 May 17, 2025 •

edited

Loading

Umeshkumar9414 commented May 17, 2025 •

edited

Loading