Skip to content

HBASE-24826 Add some comments for processlist in hbase shell #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saintstack merged 3 commits into from
Aug 7, 2020
Merged

HBASE-24826 Add some comments for processlist in hbase shell #2207

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed43153
HBASE-24826 Add some comments for processlist in hbase shell
bsglz Aug 6, 2020
71c5394
fix review issue
bsglz Aug 7, 2020
82c3af3
remove blank line
bsglz Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions hbase-shell/src/main/ruby/shell/commands/processlist.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ def help

hbase> processlist
hbase> processlist 'all'
hbase> processlist 'general'
hbase> processlist 'handler'
hbase> processlist 'rpc'
hbase> processlist 'operation'
hbase> processlist 'general' //non-RPC Tasks, such as compact, flush etc

@bitoffdev bitoffdev Aug 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @bsglz! Documentation like this is a little inconsistent in format throughout our commands, but I think it would be good to follow the precedent of the RSGroup commands and place these comments on the preceding lines with a ruby-style comment (#) since the shell is ruby.

Ex:

hbase/hbase-shell/src/main/ruby/shell/commands/set_peer_tableCFs.rb

Line 35 in 8003a15

# set table-cfs config is null, then the namespaces config decide which

@bsglz bsglz Aug 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix later.
Thanks.

hbase> processlist 'handler' //RPC Handler Tasks
hbase> processlist 'rpc' //RPC Handler Tasks which state is RUNNING
hbase> processlist 'operation' //RPC Handler Tasks which state is RUNNING and from client
hbase> processlist 'all','host187.example.com'
hbase> processlist 'all','host187.example.com,16020'
hbase> processlist 'all','host187.example.com,16020,1289493121758'
Expand Down