Skip to content

HBASE-29476 Docker Image Creation fails during precommit #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petersomogyi merged 1 commit into from
Jul 29, 2025
Merged

HBASE-29476 Docker Image Creation fails during precommit #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev-support/jenkins/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# Dockerfile for hbase-connectors pre-commit build.
# https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build

FROM maven:3.6-jdk-8
FROM maven:3.8-jdk-8
Copy link
Contributor

@NihalJain NihalJain Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so changing this fixes the build right?

Copy link
Contributor Author

@petersomogyi petersomogyi Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.


# hadolint ignore=DL3008
RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
Expand All @@ -31,7 +31,7 @@ RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
###
# Avoid out of memory errors in builds
###
ENV MAVEN_OPTS -Xmx3g
ENV MAVEN_OPTS=-Xmx3g
Copy link
Contributor

@NihalJain NihalJain Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change needed?

Copy link
Contributor Author

@petersomogyi petersomogyi Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build showed a warning for legacy formar.

 1 warning found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 34)


CMD ["/bin/bash"]

Expand Down