-
Notifications
You must be signed in to change notification settings - Fork 178
HBASE-29476 Docker Image Creation fails during precommit #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is the version currently used by the hbase-operator-tools repository. The |
| # https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build | ||
|
|
||
| FROM maven:3.6-jdk-8 | ||
| FROM maven:3.8-jdk-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so changing this fixes the build right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
| # Avoid out of memory errors in builds | ||
| ### | ||
| ENV MAVEN_OPTS -Xmx3g | ||
| ENV MAVEN_OPTS=-Xmx3g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build showed a warning for legacy formar.
1 warning found (use docker --debug to expand):
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 34)
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
No description provided.