Skip to content

YARN-11835 DockerContainerDeletionTask did not clear tasks in leveldb #7811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgzdot wants to merge 1 commit into from
Closed

YARN-11835 DockerContainerDeletionTask did not clear tasks in leveldb #7811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...p/yarn/server/nodemanager/containermanager/deletion/task/DockerContainerDeletionTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public void run() {
LinuxContainerExecutor exec = ((LinuxContainerExecutor)
getDeletionService().getContainerExecutor());
exec.removeDockerContainer(containerId);
deletionTaskFinished();
Copy link
Contributor

@zeekling zeekling Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is make sense for deletion,I'm wondering if I need to set the status of the deletionTask after removeDockerContainer fails

Copy link
Contributor Author

@dgzdot dgzdot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have considered it more thoroughly, so that there is still a chance to clean it up again after the deletion fails.

}

/**
Expand Down Expand Up @@ -86,4 +87,4 @@ public DeletionServiceDeleteTaskProto convertDeletionTaskToProto() {
}
return builder.build();
}
}
}