Skip to content

HDFS-17679 Use saslClient#hasInitialResponse() instead of heuristics in SaslParticipant#createFirstMessage() #7201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szetszwo merged 1 commit into from
Dec 6, 2024
Merged

HDFS-17679 Use saslClient#hasInitialResponse() instead of heuristics in SaslParticipant#createFirstMessage() #7201

szetszwo merged 1 commit into from
Dec 6, 2024

Conversation

@stoty
Copy link
Contributor

@stoty stoty commented Dec 2, 2024 •
edited by szetszwo
Loading

Description of PR

HDFS-17679
Use the proper SASL API to determine if SASL Client sends a non-empty inital response

How was this patch tested?

Not tested manually, CI should tell us if more changes are needed.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@stoty
Copy link
Contributor Author

stoty commented Dec 2, 2024

@szetszwo This is the fix to avoid the DIGEST heuristics.

@stoty
Copy link
Contributor Author

stoty commented Dec 2, 2024

FYI @jojochuang

@stoty stoty mentioned this pull request Dec 2, 2024
Merged
4 tasks
@hadoop-yetus
Copy link

hadoop-yetus commented Dec 2, 2024

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 11m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 34s trunk passed
+1 💚 compile 0m 59s trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 compile 0m 51s trunk passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 checkstyle 0m 34s trunk passed
+1 💚 mvnsite 0m 56s trunk passed
+1 💚 javadoc 0m 51s trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 41s trunk passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 2m 31s trunk passed
+1 💚 shadedclient 34m 16s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 46s the patch passed
+1 💚 compile 0m 49s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javac 0m 49s the patch passed
+1 💚 compile 0m 42s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 javac 0m 42s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 20s the patch passed
+1 💚 mvnsite 0m 45s the patch passed
+1 💚 javadoc 0m 36s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 33s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 2m 32s the patch passed
+1 💚 shadedclient 34m 11s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 25s hadoop-hdfs-client in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
139m 14s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7201/1/artifact/out/Dockerfile
GITHUB PR #7201
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 8fa1261f4a55 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 46d80d1
Default Java Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7201/1/testReport/
Max. process+thread count 738 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7201/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@szetszwo szetszwo changed the title HDFS-17679 Use saslClient#hasInitialResponse() instead of heuristics … HDFS-17679 Use saslClient#hasInitialResponse() instead of heuristics in SaslParticipant#createFirstMessage() Dec 3, 2024
szetszwo
szetszwo approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo szetszwo merged commit 86d8fa6 into apache:trunk Dec 6, 2024
1 of 3 checks passed
p-szucs pushed a commit to p-szucs/hadoop that referenced this pull request Oct 22, 2025
@stoty @MikaelSmith
CDPD-90798: HDFS-17679 Use saslClient#hasInitialResponse() instead of…
bd0f557 
… heuristics in SaslParticipant#createFirstMessage() (apache#7201)

(cherry picked from commit e42d0bf3620d2618df78a1be03a78c7159c367aa)
Change-Id: I986140b0204c253401a50210df39f3c48e0323d0
susheelgupta7 pushed a commit to susheel-gupta/hadoop that referenced this pull request Dec 22, 2025
Revert CDPD-90798. Backport FIPS SASL fixes to cdh_main. (apache#698)
9d3a4c0 
* CDPD-90798. Revert "CDPD-90798: Use loadDefaults == true. (apache#188)"
This reverts commit 255b484.

* CDPD-90798. Revert "CDPD-90798: Change back to env having a higher precedence than conf."
This reverts commit 90fe047.

* CDPD-90798. Revert "CDPD-90798: CDPD-76124.SaslMechanismFactory: Fixed typo in conf vs. env precedence logic"
This reverts commit 5496de1.

* CDPD-90798. Revert "CDPD-90798: HADOOP-19359. Accelerate token negotiation for other similar mechanisms."
This reverts commit 86f58d4.

* CDPD-90798. Revert "CDPD-90798: HDFS-17679 Use saslClient#hasInitialResponse() instead of heuristics in SaslParticipant#createFirstMessage() (apache#7201)"
This reverts commit bd0f557.

* CDPD-90798. Revert "CDPD-90798: HDFS-17668 Treat null SASL negotiated QOP as auth in DataTransferSasl… (apache#7171)"
This reverts commit 20eb4e5.

* CDPD-90798. Revert "CDPD-90798: HADOOP-19342. SaslRpcServer.AuthMethod print INFO messages in client."
This reverts commit 4c7ddb3.

* CDPD-90798. Revert "CDPD-90798: HADOOP-19306. Support user defined auth Callback in SaslRpcServer. (apache#7140)"
This reverts commit 1c0bd3d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szetszwo szetszwo szetszwo approved these changes

Assignees

No one assigned

Labels

HDFS trunk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stoty @hadoop-yetus @szetszwo