HDDS-1390 - Remove hk2 dependency exclusions from ozone s3gateway mod…

[avijayanhwx]

…ule.

Some hk2 transitive dependencies were mistakenly excluded in HDDS-1358Link to solve maven enforcer plugin issues. This jira cleans that up.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	29	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	49	Maven dependency ordering for branch
+1	mvninstall	1044	trunk passed
+1	compile	109	trunk passed
+1	mvnsite	77	trunk passed
+1	shadedclient	1915	branch has no errors when building and testing our client artifacts.
+1	javadoc	39	trunk passed
		_ Patch Compile Tests _
0	mvndep	10	Maven dependency ordering for patch
+1	mvninstall	66	the patch passed
+1	compile	103	the patch passed
+1	javac	103	the patch passed
+1	mvnsite	53	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedclient	694	patch has no errors when building and testing our client artifacts.
+1	javadoc	40	the patch passed
		_ Other Tests _
+1	unit	33	s3gateway in the patch passed.
-1	unit	1423	integration-test in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		4564

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.TestSecureOzoneCluster
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.hdds.scm.pipeline.TestPipelineClose
	hadoop.ozone.om.TestScmChillMode

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-698/1/artifact/out/Dockerfile
GITHUB PR	#698
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname	Linux 808918324bc2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d2141ef
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-698/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-698/1/testReport/
Max. process+thread count	4998 (vs. ulimit of 5500)
modules	C: hadoop-ozone/s3gateway hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-698/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	28	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	49	Maven dependency ordering for branch
+1	mvninstall	1125	trunk passed
+1	compile	117	trunk passed
+1	mvnsite	71	trunk passed
+1	shadedclient	1994	branch has no errors when building and testing our client artifacts.
+1	javadoc	38	trunk passed
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
+1	mvninstall	64	the patch passed
+1	compile	121	the patch passed
+1	javac	121	the patch passed
+1	mvnsite	59	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedclient	765	patch has no errors when building and testing our client artifacts.
+1	javadoc	33	the patch passed
		_ Other Tests _
+1	unit	35	s3gateway in the patch passed.
-1	unit	731	integration-test in the patch failed.
+1	asflicense	30	The patch does not generate ASF License warnings.
		4041

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestOmMetrics
	hadoop.ozone.om.TestScmChillMode

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-698/2/artifact/out/Dockerfile
GITHUB PR	#698
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname	Linux 11ba88b816af 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 77fe51e
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-698/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-698/2/testReport/
Max. process+thread count	4128 (vs. ulimit of 5500)
modules	C: hadoop-ozone/s3gateway hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-698/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	29	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	11	Maven dependency ordering for branch
+1	mvninstall	1017	trunk passed
+1	compile	104	trunk passed
+1	mvnsite	59	trunk passed
+1	shadedclient	1826	branch has no errors when building and testing our client artifacts.
+1	javadoc	35	trunk passed
		_ Patch Compile Tests _
0	mvndep	11	Maven dependency ordering for patch
+1	mvninstall	60	the patch passed
+1	compile	101	the patch passed
+1	javac	101	the patch passed
+1	mvnsite	55	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	2	The patch has no ill-formed XML file.
+1	shadedclient	686	patch has no errors when building and testing our client artifacts.
+1	javadoc	32	the patch passed
		_ Other Tests _
+1	unit	34	s3gateway in the patch passed.
-1	unit	1021	integration-test in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		4048

Reason	Tests
Failed junit tests	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.om.TestScmChillMode

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-698/3/artifact/out/Dockerfile
GITHUB PR	#698
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname	Linux c0d852c57847 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 77fe51e
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-698/3/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-698/3/testReport/
Max. process+thread count	4231 (vs. ulimit of 5500)
modules	C: hadoop-ozone/s3gateway hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-698/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[elek]

Thank you very much the patch @avijayanhwx. Unfortunately it's not enough:

Maven dependency plugin (which is used in the hadoop-ozone/dist) resolves the dependencies of the project but during the maven dependency resolution only the newest artifact is used.

In this specific case different version is used from 'guice-bridge' in ozone-recon and s3g. As we have a classpath description based classpath assembly it shouldn't be a problem. At runtime it's possible to use different jars, but at package time we should copy manually the older jar files in this case.

But as you are free to choose any version of the guice binding, I would propose to use exactly the same version in s3g and recon.

Can you please change the version in ozone-recon?

--- a/hadoop-ozone/ozone-recon/pom.xml
+++ b/hadoop-ozone/ozone-recon/pom.xml
@@ -161,7 +161,7 @@
     <dependency>
       <groupId>org.glassfish.hk2</groupId>
       <artifactId>guice-bridge</artifactId>
-      <version>2.5.0</version>
+      <version>2.5.0-b42</version>
     </dependency>
     <dependency>
       <groupId>org.glassfish.jersey.core</groupId>

[elek]

Sorry, I missed that you did almost the same. I tested accidentally the patch file and not the PR. This PR seems to be fine. I started a new build (and fixed a Jenkinsfile problem: the working directory was not cleaned).

[bharatviswa504]

+1 LGTM.
I will commit this shortly. Acceptance tests are passing with this.

Thank You @avijayanhwx for the quick fix, and @elek for the review.