Skip to content

Conversation

@HarshitGupta11
Copy link
Contributor

Description of PR

Upgrading aws sdk to 2.25.53

How was this patch tested?

The patch was tested using documentation on access points, instance profile roles and scale tests against us-west-2.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 44s Maven dependency ordering for branch
+1 💚 mvninstall 32m 8s trunk passed
+1 💚 compile 17m 17s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 compile 16m 18s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 mvnsite 25m 18s trunk passed
+1 💚 javadoc 8m 42s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 8m 4s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 shadedclient 49m 34s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 1m 18s Maven dependency ordering for patch
+1 💚 mvninstall 29m 44s the patch passed
+1 💚 compile 16m 57s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javac 16m 57s the patch passed
+1 💚 compile 15m 54s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 javac 15m 54s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 18m 58s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 40s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 8m 4s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 shadedclient 51m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 766m 46s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 40s The patch does not generate ASF License warnings.
1072m 58s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestDatanodeManager
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6900/1/artifact/out/Dockerfile
GITHUB PR #6900
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux dd5a625a7ecf 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 68a70dd
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6900/1/testReport/
Max. process+thread count 4563 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6900/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@singhpk234
Copy link

@HarshitGupta11 if possible can you please bump this to 2.25.70 instead, we are pursuing another change from s3 which is required from S3 Access grants which release contains i.e support for Copy and Delete Obj.

@steveloughran
Copy link
Contributor

@singhpk234 how about we merge this and you do the followup JIRA for the new update with a full qualification as per testing.md

Harshit has already done a full stack regression test with this one and so while increasing the version number might seem minor, the retesting is the work.

If you don't have an ASF JIRA account, follow the jira instructions, say you want to work on s3a integration issues and we will grant it.

@steveloughran steveloughran merged commit b1d96f6 into apache:trunk Jul 8, 2024
@steveloughran
Copy link
Contributor

merged, will cherrypick and retest on branch-3.4.
@singhpk234 over to you for the followup.

steveloughran pushed a commit that referenced this pull request Jul 8, 2024
KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Sep 9, 2024
Hexiaoqiao pushed a commit to Hexiaoqiao/hadoop that referenced this pull request Sep 12, 2024
asfgit pushed a commit that referenced this pull request Sep 16, 2024
This reverts commit fc86a52.

This rollback is due to:

HADOOP-19272. S3A: AWS SDK 2.25.53 warnings logged about
              transfer manager not using CRT client

Change-Id: I324f75d62daa02650ff9d199a2e0fc465a2ea28a
dongjoon-hyun added a commit to apache/spark that referenced this pull request Jan 17, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade AWS SDK v2 to 2.25.53.

### Why are the changes needed?

Like HADOOP-19195 (Apache Hadoop 3.4.2+), Apache Spark 4.0.0 had better use the latest one.
- apache/hadoop#6900

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49533 from dongjoon-hyun/SPARK-50859.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun added a commit to apache/spark that referenced this pull request Jan 17, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade AWS SDK v2 to 2.25.53.

### Why are the changes needed?

Like HADOOP-19195 (Apache Hadoop 3.4.2+), Apache Spark 4.0.0 had better use the latest one.
- apache/hadoop#6900

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49533 from dongjoon-hyun/SPARK-50859.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit baf13fb)
Signed-off-by: Dongjoon Hyun <[email protected]>
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade AWS SDK v2 to 2.25.53.

### Why are the changes needed?

Like HADOOP-19195 (Apache Hadoop 3.4.2+), Apache Spark 4.0.0 had better use the latest one.
- apache/hadoop#6900

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49533 from dongjoon-hyun/SPARK-50859.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 7ba7dd5)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants