Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Add jaxb-core and some javax artifacts to hadoop-ozone-tools dependencies to make ozone genconf work with JDK11, too.

https://issues.apache.org/jira/browse/HDDS-1351

How was this patch tested?

$ mvn -Phdds -DskipTests -Dmaven.javadoc.skip=true -Pdist -Dtar -DskipShade -am -pl :hadoop-ozone-dist clean package
$ cd $(git rev-parse --show-toplevel)/hadoop-ozone/dist/target/ozone-*-SNAPSHOT/compose/ozone
$ docker-compose run datanode ozone genconf /tmp
ozone-site.xml has been generated at /tmp

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ ozone-0.4 Compile Tests _
+1 mvninstall 1048 ozone-0.4 passed
-1 compile 61 tools in ozone-0.4 failed.
-1 mvnsite 27 tools in ozone-0.4 failed.
+1 shadedclient 1778 branch has no errors when building and testing our client artifacts.
+1 javadoc 18 ozone-0.4 passed
_ Patch Compile Tests _
-1 mvninstall 22 tools in the patch failed.
-1 compile 25 tools in the patch failed.
-1 javac 25 tools in the patch failed.
-1 mvnsite 22 tools in the patch failed.
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 727 patch has no errors when building and testing our client artifacts.
+1 javadoc 17 the patch passed
_ Other Tests _
-1 unit 22 tools in the patch failed.
+1 asflicense 24 The patch does not generate ASF License warnings.
2813
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/artifact/out/Dockerfile
GITHUB PR #660
JIRA Issue HDDS-1351
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux 68aebaf3683f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision ozone-0.4 / f2dee89
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/artifact/out/branch-compile-hadoop-ozone_tools.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/artifact/out/branch-mvnsite-hadoop-ozone_tools.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/artifact/out/patch-mvninstall-hadoop-ozone_tools.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/artifact/out/patch-compile-hadoop-ozone_tools.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/artifact/out/patch-compile-hadoop-ozone_tools.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/artifact/out/patch-mvnsite-hadoop-ozone_tools.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/artifact/out/patch-unit-hadoop-ozone_tools.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/testReport/
Max. process+thread count 441 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-660/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@xiaoyuyao
Copy link
Contributor

xiaoyuyao commented Mar 29, 2019

+1. Just notice #660 is for ozone-0.4 and #659 is for trunk.
Why we need different dependencies?

@adoroszlai
Copy link
Contributor Author

+1. Just notice #660 is for ozone-0.4 and #659 is for trunk.
Why we need different dependencies?

Nice catch.

I was using different compose files for different branches. We need the other 2 dependencies for jdk11 for trunk, too.

Pushed additional commit to the other PR.

@xiaoyuyao
Copy link
Contributor

Actually we usually only need one PR for trunk and then cherry-pick the change to ozone-0.4.

@adoroszlai
Copy link
Contributor Author

Closing, since identical to trunk PR.

@adoroszlai adoroszlai closed this Mar 29, 2019
@adoroszlai adoroszlai deleted the HDDS-1351_ozone-0.4 branch March 29, 2019 18:24
susheelgupta7 pushed a commit to susheel-gupta/hadoop that referenced this pull request Dec 22, 2025
…pache#660)

* Revert "CDPD-91258: remove duplicate container servlet"

This reverts commit 4e6c395.

* Revert "CDPD-91258: remove the test scope"

This reverts commit e82b954.

* Revert "CDPD-91258: adding another jersey dependencies"

This reverts commit 0c53e64.

* Revert "CDPD-91258: adding back the test scope for jersey-media-jaxb"

This reverts commit 0e18dc7.

* Revert "CDPD-91258: add missing jersey container servlet"

This reverts commit 31cbf61.

* Revert "CDPD-91258. Shading jersey libs for MR Pi job"

This reverts commit 8d8d975.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants