Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Add jaxb-core to hadoop-ozone-tools dependencies to make ozone genconf work again.

https://issues.apache.org/jira/browse/HDDS-1351

How was this patch tested?

$ mvn -Phdds -DskipTests -Dmaven.javadoc.skip=true -Pdist -Dtar -DskipShade -am -pl :hadoop-ozone-dist clean package
$ cd $(git rev-parse --show-toplevel)/hadoop-ozone/dist/target/ozone-*-SNAPSHOT/compose/ozones3
$ docker-compose run datanode ozone genconf /tmp
ozone-site.xml has been generated at /tmp

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 27 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1027 trunk passed
+1 compile 58 trunk passed
+1 mvnsite 31 trunk passed
+1 shadedclient 1789 branch has no errors when building and testing our client artifacts.
+1 javadoc 19 trunk passed
_ Patch Compile Tests _
+1 mvninstall 34 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
+1 mvnsite 23 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 685 patch has no errors when building and testing our client artifacts.
+1 javadoc 17 the patch passed
_ Other Tests _
+1 unit 63 tools in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
2821
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-659/1/artifact/out/Dockerfile
GITHUB PR #659
JIRA Issue HDDS-1351
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux 0fe4c6c24cf7 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 4cceeb2
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-659/1/testReport/
Max. process+thread count 2388 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-659/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 26 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 992 trunk passed
+1 compile 63 trunk passed
+1 mvnsite 30 trunk passed
+1 shadedclient 1726 branch has no errors when building and testing our client artifacts.
+1 javadoc 23 trunk passed
_ Patch Compile Tests _
+1 mvninstall 34 the patch passed
+1 compile 25 the patch passed
+1 javac 24 the patch passed
+1 mvnsite 24 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 707 patch has no errors when building and testing our client artifacts.
+1 javadoc 21 the patch passed
_ Other Tests _
+1 unit 66 tools in the patch passed.
+1 asflicense 29 The patch does not generate ASF License warnings.
2793
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-659/2/artifact/out/Dockerfile
GITHUB PR #659
JIRA Issue HDDS-1351
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux 116c4791447d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / f41f938
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-659/2/testReport/
Max. process+thread count 2519 (vs. ulimit of 5500)
modules C: hadoop-ozone/tools U: hadoop-ozone/tools
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-659/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@xiaoyuyao xiaoyuyao merged commit 7dc0ecc into apache:trunk Mar 29, 2019
asfgit pushed a commit that referenced this pull request Mar 29, 2019
…ibuted by Doroszlai Attila.

This closes #659.

(cherry picked from commit 7dc0ecc)
@adoroszlai adoroszlai deleted the HDDS-1351_trunk branch April 1, 2019 02:43
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Author: [email protected] <[email protected]>
Author: rmatharu <[email protected]>

Reviewers: Jagadish<[email protected]>

Closes apache#659 from rmatharu/monitoringdoc
susheelgupta7 pushed a commit to susheel-gupta/hadoop that referenced this pull request Dec 22, 2025
…oop-client-api" (apache#659)

This reverts commit 5822ea3ed0872f5ae856cf8b9e56d88089365410 after
CDPD-91275. HADOOP-18750 has not been merged upstream and has other
consequences to breaking the shading around javax/servlet. The original
issue with spark3 is no longer present because they've stopped using
hadoop-client-api.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants