Skip to content

HDFS-14361:SNN will always upload fsimage #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hunshenshi wants to merge 3 commits into from
Closed

HDFS-14361:SNN will always upload fsimage #592

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c13222
Merge pull request #1 from apache/trunk
hunshenshi Mar 9, 2019
d90a4db
Merge pull request #2 from apache/trunk
hunshenshi Mar 12, 2019
99f6e06
HDFS-14361:SNN will always upload fsimage
hunshenshi Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...oop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ private void doCheckpoint(boolean sendCheckpoint) throws InterruptedException, I
// Acquire cpLock to make sure no one is modifying the name system.
// It does not need the full namesystem write lock, since the only thing
// that modifies namesystem on standby node is edit log replaying.
// checkpoint是namespace的一个快照，所以在dump快照的时候需要锁，避免修改namespace的内容，
// 这也是checkpoint要在snn上执行的一个原因
namesystem.cpLockInterruptibly();
try {
assert namesystem.getEditLog().isOpenForRead() :
Expand Down Expand Up @@ -265,8 +267,8 @@ public TransferFsImage.TransferResult call()
//Update only when response from remote about success or
lastUploadTime = monotonicNow();
// we are primary if we successfully updated the ANN
this.isPrimaryCheckPointer = success;
}
this.isPrimaryCheckPointer = success;
// cleaner than copying code for multiple catch statements and better than catching all
// exceptions, so we just handle the ones we expect.
if (ie != null || ioe != null) {
Expand Down