You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If sendRequest is true, SNN will upload fsimage. But isPrimaryCheckPointer always is true,
if (ie == null && ioe == null) {
//Update only when response from remote about success orlastUploadTime = monotonicNow();
// we are primary if we successfully updated the ANNthis.isPrimaryCheckPointer = success;
}
isPrimaryCheckPointer should be outside the if condition.
If the ANN update was not successful, then isPrimaryCheckPointer should be set to false.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1206
trunk passed
+1
compile
67
trunk passed
+1
checkstyle
57
trunk passed
+1
mvnsite
67
trunk passed
+1
shadedclient
799
branch has no errors when building and testing our client artifacts.
+1
findbugs
118
trunk passed
+1
javadoc
48
trunk passed
_ Patch Compile Tests _
+1
mvninstall
58
the patch passed
+1
compile
54
the patch passed
+1
javac
54
the patch passed
+1
checkstyle
48
the patch passed
+1
mvnsite
59
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
761
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1115
trunk passed
+1
compile
63
trunk passed
+1
checkstyle
53
trunk passed
+1
mvnsite
68
trunk passed
+1
shadedclient
807
branch has no errors when building and testing our client artifacts.
+1
findbugs
121
trunk passed
+1
javadoc
52
trunk passed
_ Patch Compile Tests _
+1
mvninstall
61
the patch passed
+1
compile
57
the patch passed
+1
javac
57
the patch passed
+1
checkstyle
49
the patch passed
+1
mvnsite
61
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
749
patch has no errors when building and testing our client artifacts.
Currently we don't set application acl for container launch context. See https://hadoop.apache.org/docs/r2.6.4/api/org/apache/hadoop/yarn/api/records/ContainerLaunchContext.html#setApplicationACLs(java.util.Map)
This could potentially cause problem if samza job is running on a secured YARN cluster. Say user A submits the job, then by default only user A can view the log and the status of the job. Even worse case is that user A submits the job through some proxy account, then even user A herself/himself couldn't access to logs/status of the application.
We need to make some changes for the YARN application submission to set application acls in launch context as configured.
Author: Hai Lu <[email protected]>
Reviewers: Jagadish<[email protected]>
Closesapache#592 from lhaiesp/master
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to HDFS-12248.
If sendRequest is true, SNN will upload fsimage. But isPrimaryCheckPointer always is true,
isPrimaryCheckPointer should be outside the if condition.
If the ANN update was not successful, then isPrimaryCheckPointer should be set to false.