Skip to content

Conversation

@hunshenshi
Copy link
Contributor

Related to HDFS-12248.

boolean sendRequest = isPrimaryCheckPointer
    || secsSinceLastUpload >= checkpointConf.getQuietPeriod();
doCheckpoint(sendRequest);

If sendRequest is true, SNN will upload fsimage. But isPrimaryCheckPointer always is true,

if (ie == null && ioe == null) {
  //Update only when response from remote about success or
  lastUploadTime = monotonicNow();
  // we are primary if we successfully updated the ANN
  this.isPrimaryCheckPointer = success;
}

isPrimaryCheckPointer should be outside the if condition.

If the ANN update was not successful, then isPrimaryCheckPointer should be set to false.

@hunshenshi hunshenshi closed this Mar 12, 2019
@hunshenshi hunshenshi reopened this Mar 12, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 1028 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1206 trunk passed
+1 compile 67 trunk passed
+1 checkstyle 57 trunk passed
+1 mvnsite 67 trunk passed
+1 shadedclient 799 branch has no errors when building and testing our client artifacts.
+1 findbugs 118 trunk passed
+1 javadoc 48 trunk passed
_ Patch Compile Tests _
+1 mvninstall 58 the patch passed
+1 compile 54 the patch passed
+1 javac 54 the patch passed
+1 checkstyle 48 the patch passed
+1 mvnsite 59 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 761 patch has no errors when building and testing our client artifacts.
+1 findbugs 125 the patch passed
+1 javadoc 46 the patch passed
_ Other Tests _
-1 unit 5604 hadoop-hdfs in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
10224
Reason Tests
Failed junit tests hadoop.hdfs.server.datanode.TestBPOfferService
hadoop.hdfs.TestRollingUpgrade
hadoop.hdfs.tools.TestDFSZKFailoverController
hadoop.hdfs.qjournal.client.TestQJMWithFaults
hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-592/1/artifact/out/Dockerfile
GITHUB PR #592
JIRA Issue HDFS-14361
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 3a2b70b36cb8 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c730786
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-592/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-592/1/testReport/
Max. process+thread count 2871 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-592/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1115 trunk passed
+1 compile 63 trunk passed
+1 checkstyle 53 trunk passed
+1 mvnsite 68 trunk passed
+1 shadedclient 807 branch has no errors when building and testing our client artifacts.
+1 findbugs 121 trunk passed
+1 javadoc 52 trunk passed
_ Patch Compile Tests _
+1 mvninstall 61 the patch passed
+1 compile 57 the patch passed
+1 javac 57 the patch passed
+1 checkstyle 49 the patch passed
+1 mvnsite 61 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 749 patch has no errors when building and testing our client artifacts.
+1 findbugs 128 the patch passed
+1 javadoc 49 the patch passed
_ Other Tests _
-1 unit 6290 hadoop-hdfs in the patch failed.
+1 asflicense 36 The patch does not generate ASF License warnings.
9838
Reason Tests
Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController
hadoop.hdfs.TestRollingUpgrade
hadoop.hdfs.server.datanode.TestBPOfferService
hadoop.hdfs.server.datanode.TestDirectoryScanner
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-592/2/artifact/out/Dockerfile
GITHUB PR #592
JIRA Issue HDFS-14361
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux d201d7a9d7c6 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c730786
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-592/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-592/2/testReport/
Max. process+thread count 2720 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-592/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Currently we don't set application acl for container launch context. See https://hadoop.apache.org/docs/r2.6.4/api/org/apache/hadoop/yarn/api/records/ContainerLaunchContext.html#setApplicationACLs(java.util.Map)

This could potentially cause problem if samza job is running on a secured YARN cluster. Say user A submits the job, then by default only user A can view the log and the status of the job. Even worse case is that user A submits the job through some proxy account, then even user A herself/himself couldn't access to logs/status of the application.

We need to make some changes for the YARN application submission to set application acls in launch context as configured.

Author: Hai Lu <[email protected]>

Reviewers: Jagadish<[email protected]>

Closes apache#592 from lhaiesp/master
@github-actions
Copy link
Contributor

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.

@github-actions github-actions bot added the Stale label Dec 24, 2025
@github-actions github-actions bot closed this Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants