Skip to content

HDFS-16618. sync_file_range error should include more volume/file info #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomscut merged 2 commits into from
Jun 7, 2022
Merged

HDFS-16618. sync_file_range error should include more volume/file info #4402

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75cf43a
HDFS-16618. sync_file_range error should include more volume and file…
virajjasani Jun 5, 2022
ed59324
removing extra space - addressing review
virajjasani Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions ...java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetAsyncDiskService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,20 @@ synchronized void shutdown() {
}
}

public void submitSyncFileRangeRequest(FsVolumeImpl volume,
final ReplicaOutputStreams streams, final long offset, final long nbytes,
final int flags) {
execute(volume, new Runnable() {
@Override
public void run() {
public void submitSyncFileRangeRequest(FsVolumeImpl volume, final ReplicaOutputStreams streams,
final long offset, final long nbytes, final int flags) {
execute(volume, () -> {
try {
streams.syncFileRangeIfPossible(offset, nbytes, flags);
} catch (NativeIOException e) {
try {
streams.syncFileRangeIfPossible(offset, nbytes, flags);
} catch (NativeIOException e) {
LOG.warn("sync_file_range error", e);
LOG.warn("sync_file_range error. Volume: {} , Capacity: {}, Available space: {}, "

@tomscut tomscut Jun 6, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LOG.warn("sync_file_range error. Volume: {} , Capacity: {}, Available space: {}, "
LOG.warn("sync_file_range error. Volume: {}, Capacity: {}, Available space: {}, "

@tomscut tomscut Jun 6, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @virajjasani , please remove this extra space.

+ "File range offset: {}, length: {}, flags: {}", volume, volume.getCapacity(),
volume.getAvailable(), offset, nbytes, flags, e);
} catch (IOException ioe) {
LOG.warn("sync_file_range error. Volume: {} , Capacity: {}, "

@tomscut tomscut Jun 6, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LOG.warn("sync_file_range error. Volume: {} , Capacity: {}, "
LOG.warn("sync_file_range error. Volume: {}, Capacity: {}, "

+ "File range offset: {}, length: {}, flags: {}", volume, volume.getCapacity(),
offset, nbytes, flags, e);
}
}
});
Expand Down