HDFS-16618. sync_file_range error should include more volume/file info#4402
Merged
tomscut merged 2 commits intoapache:trunkfrom Jun 7, 2022
Merged
HDFS-16618. sync_file_range error should include more volume/file info#4402tomscut merged 2 commits intoapache:trunkfrom
tomscut merged 2 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@tomscut @jojochuang could you please review this PR? |
virajjasani
changed the title
tomscut
reviewed
Jun 6, 2022
| streams.syncFileRangeIfPossible(offset, nbytes, flags); | ||
| } catch (NativeIOException e) { | ||
| LOG.warn("sync_file_range error", e); | ||
| LOG.warn("sync_file_range error. Volume: {} , Capacity: {}, Available space: {}, " |
Contributor
There was a problem hiding this comment.
Suggested change
| LOG.warn("sync_file_range error. Volume: {} , Capacity: {}, Available space: {}, " | |
| LOG.warn("sync_file_range error. Volume: {}, Capacity: {}, Available space: {}, " |
Contributor
There was a problem hiding this comment.
Hi @virajjasani , please remove this extra space.
| + "File range offset: {}, length: {}, flags: {}", volume, volume.getCapacity(), | ||
| volume.getAvailable(), offset, nbytes, flags, e); | ||
| } catch (IOException ioe) { | ||
| LOG.warn("sync_file_range error. Volume: {} , Capacity: {}, " |
Contributor
There was a problem hiding this comment.
Suggested change
| LOG.warn("sync_file_range error. Volume: {} , Capacity: {}, " | |
| LOG.warn("sync_file_range error. Volume: {}, Capacity: {}, " |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Thanks @virajjasani for your contribution! |
tomscut
pushed a commit
that referenced
this pull request
Jun 7, 2022
#4402) Signed-off-by: Tao Li <tomscut@apache.org>
tomscut
pushed a commit
that referenced
this pull request
Jun 7, 2022
#4402) Signed-off-by: Tao Li <tomscut@apache.org>
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
apache#4402) Signed-off-by: Tao Li <tomscut@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Having seen multiple sync_file_range errors recently with Bad file descriptor, it would be good to include more volume stats as well as file offset/length info with the error log to get some more insights.