HADOOP-18274. Use CMake 3.19.0 in Debian 10 by GauthamBanasandra · Pull Request #4395 · apache/hadoop

GauthamBanasandra · 2022-06-02T11:47:33Z

Description of PR

HDFS Native Client fails to build on Debian 10 due to the following error -

[WARNING] CMake Error at main/native/libhdfspp/CMakeLists.txt:68 (FetchContent_MakeAvailable):
[WARNING]   Unknown CMake command "FetchContent_MakeAvailable".
[WARNING] 
[WARNING] 
[WARNING] -- Configuring incomplete, errors occurred!

Jenkins run - https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/2/artifact/out/branch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt

This cause for this issue is that the version of CMake on Debian 10 (which is installed through apt) is 3.13 and FetchContent_MakeAvailable was introduced in CMake 3.14

Thus, we upgrade CMake by installing through the install-cmake.sh script from pkg-resolver which installs CMake 3.19.0, instead of installing CMake through apt on Debian 10.

How was this patch tested?

Hadoop Jenkins CI.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

* This PR installs CMake through the install-cmake.sh script from pkg-resolver rather than through apt in order to install CMake 3.19.

GauthamBanasandra · 2022-06-02T11:48:35Z

This PR fixes the build failure seen on #4371 (comment).

hadoop-yetus · 2022-06-02T13:37:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	45m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	hadolint	0m 0s		hadolint was not available.
+0 🆗	shellcheck	0m 0s		Shellcheck was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+0 🆗	jsonlint	0m 1s		jsonlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 6s		Maven dependency ordering for branch
+1 💚	shadedclient	38m 11s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	21m 35s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		108m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/artifact/out/Dockerfile
GITHUB PR	#4395
Optional Tests	dupname asflicense codespell detsecrets hadolint shellcheck shelldocs jsonlint
uname	Linux 57e7a529ce01 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6c4c99e`
Max. process+thread count	522 (vs. ulimit of 5500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-02T14:54:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	26m 24s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	hadolint	0m 0s		hadolint was not available.
+0 🆗	shellcheck	0m 0s		Shellcheck was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	jsonlint	0m 0s		jsonlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+0 🆗	mvndep	0m 38s		Maven dependency ordering for branch
+1 💚	shadedclient	22m 44s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 41s		Maven dependency ordering for patch
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	24m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		76m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/artifact/out/Dockerfile
GITHUB PR	#4395
Optional Tests	dupname asflicense codespell detsecrets hadolint shellcheck shelldocs jsonlint
uname	Linux 111620a9434b 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6c4c99e`
Max. process+thread count	524 (vs. ulimit of 5500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-02T14:56:21Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/console in case of problems.

hadoop-yetus · 2022-06-02T16:27:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	27m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+0 🆗	jsonlint	0m 1s		jsonlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for branch
+1 💚	shadedclient	30m 31s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	hadolint	0m 2s		No new issues.
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	shadedclient	30m 36s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		92m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/artifact/out/Dockerfile
GITHUB PR	#4395
Optional Tests	dupname asflicense codespell detsecrets hadolint shellcheck shelldocs jsonlint
uname	Linux be63464eaba4 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6c4c99e`
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/console
versions	git=2.20.1 maven=3.6.0 hadolint=1.11.1-0-g0e692dd shellcheck=0.5.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-02T16:29:12Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/console in case of problems.

hadoop-yetus · 2022-06-02T17:35:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	20m 14s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+0 🆗	jsonlint	0m 1s		jsonlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for branch
+1 💚	shadedclient	22m 17s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for patch
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	hadolint	0m 2s		No new issues.
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	shadedclient	22m 0s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		68m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/artifact/out/Dockerfile
GITHUB PR	#4395
Optional Tests	dupname asflicense codespell detsecrets hadolint shellcheck shelldocs jsonlint
uname	Linux 2638148717fb 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6c4c99e`
Max. process+thread count	521 (vs. ulimit of 5500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4395/1/console
versions	git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

HADOOP-18274. Use CMake 3.19.0 in Debian 10

6c4c99e

* This PR installs CMake through the install-cmake.sh script from pkg-resolver rather than through apt in order to install CMake 3.19.

GauthamBanasandra self-assigned this Jun 2, 2022

GauthamBanasandra added the build label Jun 2, 2022

GauthamBanasandra marked this pull request as ready for review June 2, 2022 18:09

GauthamBanasandra requested a review from goiri June 2, 2022 18:10

goiri approved these changes Jun 2, 2022

View reviewed changes

goiri merged commit 7ac2713 into apache:trunk Jun 2, 2022

GauthamBanasandra deleted the cmake-3.19-deb-10 branch June 3, 2022 04:33

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HADOOP-18274. Use CMake 3.19.0 in Debian 10 (apache#4395)

7da1c7a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-18274. Use CMake 3.19.0 in Debian 10#4395

HADOOP-18274. Use CMake 3.19.0 in Debian 10#4395
goiri merged 1 commit intoapache:trunkfrom
GauthamBanasandra:cmake-3.19-deb-10

GauthamBanasandra commented Jun 2, 2022

Uh oh!

GauthamBanasandra commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

GauthamBanasandra commented Jun 2, 2022

Description of PR

How was this patch tested?

For code changes:

Uh oh!

GauthamBanasandra commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

hadoop-yetus commented Jun 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments