HDFS-16602. Use "defined" directive along with #if by GauthamBanasandra · Pull Request #4371 · apache/hadoop

GauthamBanasandra · 2022-05-28T07:43:44Z

Description of PR

The #if preprocessor directive expects a boolean expression. Thus, we need to use the defined directive as well to check if the macro has been defined.

How was this patch tested?

Unit tests run by Jenkins CI.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

* The #if directive expects a boolean expression. This PR uses the more appropriate "defined" directive.

This reverts commit 9c80775faa889caa930a48e16f88befe4c0a233a.

hadoop-yetus · 2022-06-03T07:21:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	37m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 1s		trunk passed
+1 💚	compile	3m 52s		trunk passed
+1 💚	mvnsite	0m 49s		trunk passed
+1 💚	shadedclient	62m 35s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 25s		the patch passed
+1 💚	compile	3m 37s		the patch passed
+1 💚	cc	3m 37s		the patch passed
+1 💚	golang	3m 37s		the patch passed
+1 💚	javac	3m 37s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 27s		the patch passed
+1 💚	shadedclient	18m 54s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	32m 42s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 53s		The patch does not generate ASF License warnings.
		159m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/artifact/out/Dockerfile
GITHUB PR	#4371
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux 5c95ffd2fd24 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2c790d4`
Default Java	Red Hat, Inc.-1.8.0_332-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/testReport/
Max. process+thread count	572 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-03T09:31:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	21m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	22m 44s		trunk passed
+1 💚	compile	4m 8s		trunk passed
+1 💚	mvnsite	1m 3s		trunk passed
+1 💚	shadedclient	47m 31s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s		the patch passed
+1 💚	compile	3m 40s		the patch passed
+1 💚	cc	3m 40s		the patch passed
+1 💚	golang	3m 40s		the patch passed
+1 💚	javac	3m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 36s		the patch passed
+1 💚	shadedclient	19m 11s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	33m 3s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	1m 0s		The patch does not generate ASF License warnings.
		129m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/artifact/out/Dockerfile
GITHUB PR	#4371
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux 9136a8e62055 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2c790d4`
Default Java	Red Hat, Inc.-1.8.0_312-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/testReport/
Max. process+thread count	549 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-03T11:52:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	20m 45s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	24m 22s		trunk passed
+1 💚	compile	3m 33s		trunk passed
+1 💚	mvnsite	0m 44s		trunk passed
+1 💚	shadedclient	54m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	3m 13s		the patch passed
+1 💚	cc	3m 13s		the patch passed
+1 💚	golang	3m 13s		the patch passed
+1 💚	javac	3m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 26s		the patch passed
+1 💚	shadedclient	26m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	32m 10s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		140m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/artifact/out/Dockerfile
GITHUB PR	#4371
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux 090bce813b0b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2c790d4`
Default Java	Debian-11.0.15+10-post-Debian-1deb10u1
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/testReport/
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/console
versions	git=2.20.1 maven=3.6.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-03T14:00:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	13m 18s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	21m 25s		trunk passed
+1 💚	compile	4m 3s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	4m 1s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	0m 49s		trunk passed
+1 💚	shadedclient	50m 8s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	3m 42s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	cc	3m 42s		the patch passed
+1 💚	golang	3m 42s		the patch passed
+1 💚	javac	3m 42s		the patch passed
+1 💚	compile	3m 42s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	cc	3m 42s		the patch passed
+1 💚	golang	3m 42s		the patch passed
+1 💚	javac	3m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 27s		the patch passed
+1 💚	shadedclient	19m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	33m 0s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		127m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/artifact/out/Dockerfile
GITHUB PR	#4371
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux a30bb8ef0c3c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2c790d4`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/testReport/
Max. process+thread count	550 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4371/3/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

* The #if directive expects a boolean expression. This PR uses the more appropriate "defined" directive.

GauthamBanasandra self-assigned this May 28, 2022

GauthamBanasandra added the HDFS label May 28, 2022

This comment was marked as outdated.

Sign in to view

goiri approved these changes May 31, 2022

View reviewed changes

GauthamBanasandra force-pushed the ifdef-x-platform-types branch from ac6811f to b472514 Compare June 1, 2022 05:13

This comment was marked as outdated.

Sign in to view

GauthamBanasandra mentioned this pull request Jun 2, 2022

HADOOP-18274. Use CMake 3.19.0 in Debian 10 #4395

Merged

4 tasks

GauthamBanasandra added 3 commits June 3, 2022 10:10

Use "defined" directive for #elif

37e26e5

* The #if directive expects a boolean expression. This PR uses the more appropriate "defined" directive.

Run CI

c6374a4

Revert "Run CI"

2c790d4

This reverts commit 9c80775faa889caa930a48e16f88befe4c0a233a.

GauthamBanasandra force-pushed the ifdef-x-platform-types branch from b472514 to 2c790d4 Compare June 3, 2022 04:40

GauthamBanasandra marked this pull request as ready for review June 3, 2022 16:33

GauthamBanasandra merged commit a406f49 into apache:trunk Jun 3, 2022

GauthamBanasandra deleted the ifdef-x-platform-types branch June 3, 2022 16:35

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HDFS-16602. Use "defined" directive along with #if (apache#4371)

9d5cba6

* The #if directive expects a boolean expression. This PR uses the more appropriate "defined" directive.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

HDFS-16602. Use "defined" directive along with #if#4371

HDFS-16602. Use "defined" directive along with #if#4371
GauthamBanasandra merged 3 commits intoapache:trunkfrom
GauthamBanasandra:ifdef-x-platform-types

GauthamBanasandra commented May 28, 2022 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

hadoop-yetus commented Jun 3, 2022

Uh oh!

hadoop-yetus commented Jun 3, 2022

Uh oh!

hadoop-yetus commented Jun 3, 2022

Uh oh!

hadoop-yetus commented Jun 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

GauthamBanasandra commented May 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

hadoop-yetus commented Jun 3, 2022

Uh oh!

hadoop-yetus commented Jun 3, 2022

Uh oh!

hadoop-yetus commented Jun 3, 2022

Uh oh!

hadoop-yetus commented Jun 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GauthamBanasandra commented May 28, 2022 •

edited

Loading