MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ #4120

sekikn · 2022-03-30T02:01:42Z

Description of PR

Building MapReduce NativeTask with GCC 11, in which C++17 features are enabled by default, leads to the following error. This PR fixes this problem.

error: ISO C++17 does not allow dynamic exception specifications

How was this patch tested?

I ran the following command locally and confirmed that it succeeded.

$ mvn package -Pdist,native -DskipTests -Dtar -Dmaven.javadoc.skip=true

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2022-03-30T04:03:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	39m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 40s		trunk passed
+1 💚	compile	0m 58s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	shadedclient	55m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 22s		the patch passed
+1 💚	compile	0m 48s		the patch passed
-1 ❌	cc	0m 48s	/results-compile-cc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt	hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask generated 37 new + 78 unchanged - 37 fixed = 115 total (was 115)
+1 💚	javac	0m 48s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	shadedclient	19m 16s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 54s		hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		120m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4120/1/artifact/out/Dockerfile
GITHUB PR	#4120
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell
uname	Linux e4e8eb838ba0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cae593a`
Default Java	Red Hat, Inc.-1.8.0_322-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4120/1/testReport/
Max. process+thread count	694 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4120/1/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

iwasakims · 2022-03-30T05:04:33Z

@sekikn HADOOP-17196(#2208) replaced -std=* with CMAKE_CXX_STANDARD. How about using the CMAKE_CXX_STANDARD here too?

sekikn · 2022-03-30T06:58:17Z

@iwasakims Thank you for the comment! Updated the PR.

hadoop-yetus · 2022-03-30T08:21:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 58s		trunk passed
+1 💚	compile	0m 58s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	shadedclient	55m 46s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 22s		the patch passed
+1 💚	compile	0m 48s		the patch passed
-1 ❌	cc	0m 48s	/results-compile-cc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt	hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask generated 11 new + 104 unchanged - 11 fixed = 115 total (was 115)
+1 💚	javac	0m 48s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 23s		the patch passed
+1 💚	shadedclient	19m 13s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 51s		hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		82m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4120/2/artifact/out/Dockerfile
GITHUB PR	#4120
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell
uname	Linux 8b3e12d8cebf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bdccf18`
Default Java	Red Hat, Inc.-1.8.0_322-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4120/2/testReport/
Max. process+thread count	677 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4120/2/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

iwasakims

+1. cc warnings are not related. It should be fixed by YETUS-1107.

) (cherry picked from commit dc4a680)

iwasakims · 2022-03-30T14:00:29Z

I merged this to trunk, branch-3.3 and branch-3.2. Thanks, @sekikn.

…ache#4120) (cherry picked from commit dc4a680) Change-Id: Ia9ad34b5c3c0f767169fc48a1866c04ff73b1093

) (cherry picked from commit dc4a680) Change-Id: Ia9ad34b5c3c0f767169fc48a1866c04ff73b1093

…ache#4120)

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+

cae593a

Use CMAKE_CXX_STANDARD instead of "-std=c++11" directly

bdccf18

iwasakims approved these changes Mar 30, 2022

View reviewed changes

iwasakims merged commit dc4a680 into apache:trunk Mar 30, 2022

iwasakims pushed a commit that referenced this pull request Mar 30, 2022

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ (#4120

85843f2

) (cherry picked from commit dc4a680)

iwasakims pushed a commit that referenced this pull request Mar 30, 2022

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ (#4120

5c6547d

) (cherry picked from commit dc4a680)

sekikn deleted the MAPREDUCE-7373 branch March 30, 2022 14:22

steveloughran pushed a commit to steveloughran/hadoop that referenced this pull request Apr 5, 2022

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ (ap…

0ad812e

…ache#4120) (cherry picked from commit dc4a680) Change-Id: Ia9ad34b5c3c0f767169fc48a1866c04ff73b1093

steveloughran pushed a commit to steveloughran/hadoop that referenced this pull request Apr 12, 2022

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ (ap…

cb7d797

…ache#4120) (cherry picked from commit dc4a680) Change-Id: Ia9ad34b5c3c0f767169fc48a1866c04ff73b1093

asfgit pushed a commit that referenced this pull request Apr 13, 2022

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ (#4120

581ca34

) (cherry picked from commit dc4a680) Change-Id: Ia9ad34b5c3c0f767169fc48a1866c04ff73b1093

asfgit pushed a commit that referenced this pull request Apr 14, 2022

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ (#4120

73c459d

) (cherry picked from commit dc4a680) Change-Id: Ia9ad34b5c3c0f767169fc48a1866c04ff73b1093

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ (ap…

8ed79ab

…ache#4120)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ #4120

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ #4120

Uh oh!

sekikn commented Mar 30, 2022

Uh oh!

hadoop-yetus commented Mar 30, 2022

Uh oh!

iwasakims commented Mar 30, 2022

Uh oh!

sekikn commented Mar 30, 2022

Uh oh!

hadoop-yetus commented Mar 30, 2022

Uh oh!

iwasakims left a comment

Uh oh!

iwasakims commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ #4120

MAPREDUCE-7373. Building MapReduce NativeTask fails on Fedora 34+ #4120

Uh oh!

Conversation

sekikn commented Mar 30, 2022

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Mar 30, 2022

Uh oh!

iwasakims commented Mar 30, 2022

Uh oh!

sekikn commented Mar 30, 2022

Uh oh!

hadoop-yetus commented Mar 30, 2022

Uh oh!

iwasakims left a comment

Choose a reason for hiding this comment

Uh oh!

iwasakims commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants