Skip to content

HADOOP-17196 Fix C/C++ standard warnings #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aajisaka merged 1 commit into from
Aug 11, 2020
Merged

HADOOP-17196 Fix C/C++ standard warnings #2208

aajisaka merged 1 commit into from
Aug 11, 2020

Conversation

@GauthamBanasandra
Copy link
Member

@GauthamBanasandra GauthamBanasandra commented Aug 10, 2020 •
edited
Loading

  • Passing C/C++ standard flags -std is
    not cross-compiler friendly as not all
    compilers support all values.
  • Thus, we need to make use of the
    appropriate flags provided by CMake in
    order to specify the C/C++ standards.

@GauthamBanasandra
HADOOP-17196 Fix C/C++ standard warnings
20ac08c 
* Passing C/C++ standard flags -std is
  not cross-compiler friendly as not all
  compilers support all values.
* Thus, we need to make use of the
  appropriate flags provided by CMake in
  order to specify the C/C++ standards.
@hadoop-yetus
Copy link

hadoop-yetus commented Aug 10, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 25s Maven dependency ordering for branch
+1 💚 mvninstall 29m 28s trunk passed
+1 💚 compile 24m 7s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 20m 16s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 mvnsite 2m 9s trunk passed
+1 💚 shadedclient 97m 34s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 mvninstall 1m 17s the patch passed
+1 💚 compile 22m 29s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
-1 ❌ cc 22m 29s root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 34 new + 128 unchanged - 34 fixed = 162 total (was 162)
+1 💚 javac 22m 29s the patch passed
+1 💚 compile 20m 35s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌ cc 20m 35s root-jdkPrivateBuild-1.8.0_252-8u252-b09-118.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-118.04-b09 generated 16 new + 146 unchanged - 16 fixed = 162 total (was 162)
+1 💚 javac 20m 35s the patch passed
+1 💚 mvnsite 2m 10s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 43s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 10m 16s hadoop-common in the patch passed.
+1 💚 unit 9m 32s hadoop-hdfs-native-client in the patch passed.
+1 💚 asflicense 0m 57s The patch does not generate ASF License warnings.
186m 59s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/artifact/out/Dockerfile
GITHUB PR #2208
Optional Tests dupname asflicense compile cc mvnsite javac unit
uname Linux 0fe2e6bd1b48 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 5e0f879
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
cc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/testReport/
Max. process+thread count 2017 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-native-client U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2208/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@GauthamBanasandra
Copy link
Member Author

GauthamBanasandra commented Aug 11, 2020

The cc warnings in the above CI run are not introduced by my patch. They're due to the existing code.

@GauthamBanasandra
Copy link
Member Author

GauthamBanasandra commented Aug 11, 2020

Regarding test4tests, this patch doesn't change any behaviour thus adding/modifying tests isn't necessary.

@GauthamBanasandra
Copy link
Member Author

GauthamBanasandra commented Aug 11, 2020

@aajisaka could you please review this PR?

@aajisaka aajisaka self-requested a review August 11, 2020 07:32
aajisaka
aajisaka approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@aajisaka aajisaka merged commit 909f1e8 into apache:trunk Aug 11, 2020
aajisaka pushed a commit that referenced this pull request Aug 11, 2020
@GauthamBanasandra @aajisaka
HADOOP-17196. Fix C/C++ standard warnings (#2208)
b4a105a 
* Passing C/C++ standard flags -std is
  not cross-compiler friendly as not all
  compilers support all values.
* Thus, we need to make use of the
  appropriate flags provided by CMake in
  order to specify the C/C++ standards.

Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit 909f1e8)
@aajisaka
Copy link
Member

aajisaka commented Aug 11, 2020

Thank you @GauthamBanasandra for your contribution!

aajisaka pushed a commit that referenced this pull request Aug 11, 2020
@GauthamBanasandra @aajisaka
HADOOP-17196. Fix C/C++ standard warnings (#2208)
ff907b3 
* Passing C/C++ standard flags -std is
  not cross-compiler friendly as not all
  compilers support all values.
* Thus, we need to make use of the
  appropriate flags provided by CMake in
  order to specify the C/C++ standards.

Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit 909f1e8)
@iwasakims iwasakims mentioned this pull request Mar 30, 2022
Merged
4 tasks
iwasakims added a commit that referenced this pull request Jun 30, 2022
@iwasakims
Revert "HADOOP-17196. Fix C/C++ standard warnings (#2208)"
0fbb62a 
This reverts commit ff907b3.
iwasakims added a commit that referenced this pull request Jun 30, 2022
@iwasakims
Revert "HADOOP-17196. Fix C/C++ standard warnings (#2208)"
75c739c 
This reverts commit b4a105a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aajisaka aajisaka aajisaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GauthamBanasandra @hadoop-yetus @aajisaka