Skip to content

HDFS-16391. Avoid evaluation of LOG.debug statement in NameNodeHeartbeatService #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sodonnel merged 2 commits into from
Dec 21, 2021
Merged

HDFS-16391. Avoid evaluation of LOG.debug statement in NameNodeHeartbeatService #3820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5b7a18
HDFS-16391. Avoid evaluation of LOG.debug statement in NameNodeHeartb…
wzhallright Dec 20, 2021
91c0892
HDFS-16391. address comment
wzhallright Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...c/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,16 @@ private void updateState() {
LOG.error("Namenode is not operational: {}", getNamenodeDesc());
} else if (report.haStateValid()) {
// block and HA status available
LOG.debug("Received service state: {} from HA namenode: {}",
report.getState(), getNamenodeDesc());
if (LOG.isDebugEnabled()) {
LOG.debug("Received service state: {} from HA namenode: {}",
report.getState(), getNamenodeDesc());
}
} else if (localTarget == null) {
// block info available, HA status not expected
LOG.debug(
"Reporting non-HA namenode as operational: " + getNamenodeDesc());
if (LOG.isDebugEnabled()) {
LOG.debug(
"Reporting non-HA namenode as operational: {}", getNamenodeDesc());
}
} else {
// block info available, HA status should be available, but was not
// fetched do nothing and let the current state stand
Expand Down