HDFS-16391. Avoid evaluation of LOG.debug statement in NameNodeHeartbeatService #3820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
jojochuang
approved these changes
Dec 20, 2021
sodonnel
reviewed
Dec 20, 2021
| // block info available, HA status not expected | ||
| LOG.debug( | ||
| "Reporting non-HA namenode as operational: " + getNamenodeDesc()); | ||
| "Reporting non-HA namenode as operational: {}", getNamenodeDesc()); |
Contributor
There was a problem hiding this comment.
I think this statement really needs wrapped in an if (LOG.isDebugEnabled()). The reason is that the method call getNamenodeDesc() needs to be evaluated whether we log or not, so its result can be passed into the LOG.debug() method. Inside LOG.debug, it will skip the logging, but by then, we have already formed the string inside getNamenodeDesc() and never use it.
If we are passing an object into LOG.debug, this change would be the correct thing to do, as toString() will only get called on the object if the log message is created. However when we pass a method call into the method, it needs to be evaluated first AFAIK.
Contributor
There was a problem hiding this comment.
Note there is another debug message just above this one which looks similar and could be wrapped in a if LOG.isDebugEnabled at 270 for the same reason.
Contributor
Author
There was a problem hiding this comment.
Modified, please help review again. Thanks!
Contributor
There was a problem hiding this comment.
The latest change looks good. Thanks for changing both the log lines.
sodonnel
approved these changes
Dec 20, 2021
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
LGTM, pending a good CI run.
|
💔 -1 overall
This message was automatically generated. |
tomscut
approved these changes
Dec 20, 2021
wzhallright
force-pushed
the
HDFS-16391
branch
from
680ec9a to
91c0892
Compare
|
💔 -1 overall
This message was automatically generated. |
sodonnel
approved these changes
Dec 21, 2021
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eatService
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?JIRA:
https://issues.apache.org/jira/browse/HDFS-16391?filter=-2