Skip to content

HDFS-16370. Fix assert message for BlockInfo #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushtkn merged 2 commits into from
Dec 4, 2021
Merged

HDFS-16370. Fix assert message for BlockInfo #3747

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc00d6
HDFS-16370. Fix assert message for BlockInfo
tomscut Dec 3, 2021
82653a9
fix checkstyle
tomscut Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ct/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ BlockInfo getPrevious(int index) {
BlockInfo info = (BlockInfo)triplets[index*3+1];
assert info == null ||
info.getClass().getName().startsWith(BlockInfo.class.getName()) :
"BlockInfo is expected at " + index*3;
"BlockInfo is expected at " + (index*3+1);

@ayushtkn ayushtkn Dec 4, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Better to have some space around the values

Suggested change
"BlockInfo is expected at " + (index*3+1);
"BlockInfo is expected at " + (index * 3 + 1);

@tomscut tomscut Dec 4, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayushtkn for your comments.

return info;
}

Expand All @@ -146,7 +146,7 @@ BlockInfo getNext(int index) {
BlockInfo info = (BlockInfo)triplets[index*3+2];
assert info == null || info.getClass().getName().startsWith(
BlockInfo.class.getName()) :
"BlockInfo is expected at " + index*3;
"BlockInfo is expected at " + (index*3+2);

@ayushtkn ayushtkn Dec 4, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, Can you pad some space between the values

@tomscut tomscut Dec 4, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I fixed this.

return info;
}

Expand Down