Skip to content

HDFS-16370. Fix assert message for BlockInfo #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushtkn merged 2 commits into from
Dec 4, 2021
Merged

HDFS-16370. Fix assert message for BlockInfo #3747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc00d6
HDFS-16370. Fix assert message for BlockInfo
tomscut Dec 3, 2021
82653a9
fix checkstyle
tomscut Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions ...ct/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public BlockInfo(short size) {

public BlockInfo(Block blk, short size) {
super(blk);
this.triplets = new Object[3*size];
this.triplets = new Object[3 * size];
this.bcId = INVALID_INODE_ID;
this.replication = isStriped() ? 0 : size;
}
Expand Down Expand Up @@ -126,34 +126,34 @@ public DatanodeDescriptor getDatanode(int index) {

DatanodeStorageInfo getStorageInfo(int index) {
assert this.triplets != null : "BlockInfo is not initialized";
assert index >= 0 && index*3 < triplets.length : "Index is out of bound";
return (DatanodeStorageInfo)triplets[index*3];
assert index >= 0 && index * 3 < triplets.length : "Index is out of bound";
return (DatanodeStorageInfo)triplets[index * 3];
}

BlockInfo getPrevious(int index) {
assert this.triplets != null : "BlockInfo is not initialized";
assert index >= 0 && index*3+1 < triplets.length : "Index is out of bound";
BlockInfo info = (BlockInfo)triplets[index*3+1];
assert index >= 0 && index * 3 + 1 < triplets.length : "Index is out of bound";
BlockInfo info = (BlockInfo)triplets[index * 3 + 1];
assert info == null ||
info.getClass().getName().startsWith(BlockInfo.class.getName()) :
"BlockInfo is expected at " + index*3;
"BlockInfo is expected at " + (index * 3 + 1);
return info;
}

BlockInfo getNext(int index) {
assert this.triplets != null : "BlockInfo is not initialized";
assert index >= 0 && index*3+2 < triplets.length : "Index is out of bound";
BlockInfo info = (BlockInfo)triplets[index*3+2];
assert index >= 0 && index * 3 + 2 < triplets.length : "Index is out of bound";
BlockInfo info = (BlockInfo)triplets[index * 3 + 2];
assert info == null || info.getClass().getName().startsWith(
BlockInfo.class.getName()) :
"BlockInfo is expected at " + index*3;
"BlockInfo is expected at " + (index * 3 + 2);
return info;
}

void setStorageInfo(int index, DatanodeStorageInfo storage) {
assert this.triplets != null : "BlockInfo is not initialized";
assert index >= 0 && index*3 < triplets.length : "Index is out of bound";
triplets[index*3] = storage;
assert index >= 0 && index * 3 < triplets.length : "Index is out of bound";
triplets[index * 3] = storage;
}

/**
Expand All @@ -166,9 +166,9 @@ void setStorageInfo(int index, DatanodeStorageInfo storage) {
*/
BlockInfo setPrevious(int index, BlockInfo to) {
assert this.triplets != null : "BlockInfo is not initialized";
assert index >= 0 && index*3+1 < triplets.length : "Index is out of bound";
BlockInfo info = (BlockInfo) triplets[index*3+1];
triplets[index*3+1] = to;
assert index >= 0 && index * 3 + 1 < triplets.length : "Index is out of bound";
BlockInfo info = (BlockInfo) triplets[index * 3 + 1];
triplets[index * 3 + 1] = to;
return info;
}

Expand All @@ -182,9 +182,9 @@ BlockInfo setPrevious(int index, BlockInfo to) {
*/
BlockInfo setNext(int index, BlockInfo to) {
assert this.triplets != null : "BlockInfo is not initialized";
assert index >= 0 && index*3+2 < triplets.length : "Index is out of bound";
BlockInfo info = (BlockInfo) triplets[index*3+2];
triplets[index*3+2] = to;
assert index >= 0 && index * 3 + 2 < triplets.length : "Index is out of bound";
BlockInfo info = (BlockInfo) triplets[index * 3 + 2];
triplets[index * 3 + 2] = to;
return info;
}

Expand Down