HADOOP-17946. Upgrade commons-lang to 3.12.0 by prasad-acit · Pull Request #3575 · apache/hadoop

prasad-acit · 2021-10-21T21:31:29Z

Description of PR

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2021-10-21T22:58:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 13s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 0s		trunk passed
+1 💚	compile	0m 17s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 16s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	mvnsite	0m 21s		trunk passed
+1 💚	javadoc	0m 20s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 18s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	shadedclient	58m 10s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s		the patch passed
+1 💚	compile	0m 11s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 11s		the patch passed
+1 💚	compile	0m 11s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 11s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 14s		the patch passed
+1 💚	xml	0m 1s		The patch has no ill-formed XML file.
+1 💚	javadoc	0m 11s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 12s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	shadedclient	22m 55s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 14s		hadoop-project in the patch passed.
+1 💚	asflicense	0m 30s		The patch does not generate ASF License warnings.
		85m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3575/1/artifact/out/Dockerfile
GITHUB PR	#3575
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname	Linux ccf59e3e2a65 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7d770e9`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3575/1/testReport/
Max. process+thread count	599 (vs. ulimit of 5500)
modules	C: hadoop-project U: hadoop-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3575/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jojochuang

Can you also update our LICENSE-binary file

hadoop/LICENSE-binary

Line 253 in a73ff69

commons-lang:commons-lang:2.6

That way, it also triggers the full set of precommit tests.

prasad-acit · 2021-10-22T18:44:47Z

Thanks @jojochuang for the quick review & update.
There were 2 entries of commons-lang. 2.6 couldnt find any reference, i have deleted it & updated commons-lang3 version in license file. Can you please take a look? Thank you.
No new tests added & there are no existing UT failures with the version upgrade.

hadoop-yetus · 2021-10-23T17:37:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 38s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 28s		trunk passed
+1 💚	compile	27m 6s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	23m 21s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	mvnsite	27m 58s		trunk passed
+1 💚	javadoc	9m 13s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	8m 56s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	shadedclient	40m 25s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 24s		Maven dependency ordering for patch
+1 💚	mvninstall	25m 40s		the patch passed
+1 💚	compile	26m 31s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
-1 ❌	javac	26m 32s	/results-compile-javac-root-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt	root-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 1891 unchanged - 0 fixed = 1892 total (was 1891)
+1 💚	compile	23m 33s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-1 ❌	javac	23m 33s	/results-compile-javac-root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt	root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 generated 1 new + 1767 unchanged - 0 fixed = 1768 total (was 1767)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	24m 22s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xml	0m 1s		The patch has no ill-formed XML file.
+1 💚	javadoc	9m 5s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	8m 48s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	shadedclient	41m 16s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	1083m 13s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 45s		The patch does not generate ASF License warnings.
		1387m 34s

Reason	Tests
Failed junit tests	hadoop.yarn.csi.client.TestCsiClient
	hadoop.tools.dynamometer.TestDynamometerInfra
	hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure
	hadoop.hdfs.TestViewDistributedFileSystemWithMountLinks
	hadoop.hdfs.TestHDFSFileSystemContract

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3575/2/artifact/out/Dockerfile
GITHUB PR	#3575
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml shellcheck shelldocs
uname	Linux ad1f2042cd5b 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 58b9df0dd8f8d1d8734e537fca4ca0d72c08b756
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3575/2/testReport/
Max. process+thread count	3137 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3575/2/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-10-23T17:44:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 4s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 32s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 20s		trunk passed
+1 💚	compile	27m 46s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	22m 34s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	mvnsite	28m 16s		trunk passed
+1 💚	javadoc	9m 11s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	8m 6s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	shadedclient	39m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for patch
+1 💚	mvninstall	25m 18s		the patch passed
+1 💚	compile	27m 23s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
-1 ❌	javac	27m 23s	/results-compile-javac-root-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt	root-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 1894 unchanged - 0 fixed = 1895 total (was 1894)
+1 💚	compile	22m 38s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-1 ❌	javac	22m 38s	/results-compile-javac-root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt	root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 generated 1 new + 1768 unchanged - 0 fixed = 1769 total (was 1768)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	24m 22s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xml	0m 2s		The patch has no ill-formed XML file.
+1 💚	javadoc	9m 1s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	8m 8s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	shadedclient	40m 18s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	1083m 27s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 47s		The patch does not generate ASF License warnings.
		1385m 37s

Reason	Tests
Failed junit tests	hadoop.yarn.csi.client.TestCsiClient
	hadoop.tools.dynamometer.TestDynamometerInfra
	hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3575/3/artifact/out/Dockerfile
GITHUB PR	#3575
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml shellcheck shelldocs
uname	Linux 762b2c06b276 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6ba0a02`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3575/3/testReport/
Max. process+thread count	3073 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3575/3/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jojochuang · 2021-10-25T05:35:23Z

javac warning unrelated. They were there prior to the change.
Could you quickly check if the failed tests are related or not? Other than that I am +1

prasad-acit · 2021-10-25T19:48:27Z

javac warning unrelated. They were there prior to the change. Could you quickly check if the failed tests are related or not? Other than that I am +1

Thanks @jojochuang for the review & feedback. I have checked the test failures, none of them are related to the code changes done here. I have verified the tests locally with & without the patch.

(cherry picked from commit b923fa7)

…lang3, Commons-config2 (#121) * HADOOP-17946. Upgrade commons-lang to 3.12.0 (apache#3575) * HADOOP-19532. Update commons-lang3 to 3.17.0 (apache#7591) (apache#7648) Contributed by Istvan Toth. Signed-off-by: Shilun Fan <slfan1989@apache.org> * HADOOP-19123. Update to commons-configuration2 2.10.1 due to CVE (apache#6661). Contributed by PJ Fanning Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> --------- Signed-off-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Co-authored-by: Renukaprasad C <48682981+prasad-acit@users.noreply.github.com> Co-authored-by: Istvan Toth <stoty@apache.org> Co-authored-by: PJ Fanning <pjfanning@users.noreply.github.com>

* OSV 10934 CVE-2024-29131 | HADOOP-19123, HADOOP-19532 Bumped Commons-lang3, Commons-config2 (#121) * HADOOP-17946. Upgrade commons-lang to 3.12.0 (apache#3575) * HADOOP-19532. Update commons-lang3 to 3.17.0 (apache#7591) (apache#7648) Contributed by Istvan Toth. Signed-off-by: Shilun Fan <slfan1989@apache.org> * HADOOP-19123. Update to commons-configuration2 2.10.1 due to CVE (apache#6661). Contributed by PJ Fanning Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> --------- Signed-off-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Co-authored-by: Renukaprasad C <48682981+prasad-acit@users.noreply.github.com> Co-authored-by: Istvan Toth <stoty@apache.org> Co-authored-by: PJ Fanning <pjfanning@users.noreply.github.com> * OSV-9619 | 9572 : Bumping commons-net & commons-lang due to CVE * OSV-3108 | HADOOP-18991, CVE-2025-48734 Remove commons-beanutils dependency from (#123) Hadoop 3 --------- Signed-off-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> Co-authored-by: Renukaprasad C <48682981+prasad-acit@users.noreply.github.com> Co-authored-by: Istvan Toth <stoty@apache.org> Co-authored-by: PJ Fanning <pjfanning@users.noreply.github.com> Co-authored-by: basapuram-kumar <bsprmkumar@gmail.com>

HADOOP-17946. Upgrade commons-lang to 3.12.0

7d770e9

jojochuang requested changes Oct 22, 2021

View reviewed changes

HADOOP-17946. Upgrade commons-lang to 3.12.0, update lincense file

6ba0a02

prasad-acit force-pushed the HADOOP-17946 branch from 58b9df0 to 6ba0a02 Compare October 22, 2021 18:37

jojochuang merged commit b923fa7 into apache:trunk Oct 26, 2021

asfgit pushed a commit that referenced this pull request Nov 16, 2021

HADOOP-17946. Upgrade commons-lang to 3.12.0 (#3575)

3bb4a09

(cherry picked from commit b923fa7)

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HADOOP-17946. Upgrade commons-lang to 3.12.0 (apache#3575)

bdbfc2f

kravii pushed a commit to acceldata-io/hadoop that referenced this pull request Feb 20, 2026

HADOOP-17946. Upgrade commons-lang to 3.12.0 (apache#3575)

d36ea22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-17946. Upgrade commons-lang to 3.12.0#3575

HADOOP-17946. Upgrade commons-lang to 3.12.0#3575
jojochuang merged 2 commits intoapache:trunkfrom
prasad-acit:HADOOP-17946

prasad-acit commented Oct 21, 2021

Uh oh!

hadoop-yetus commented Oct 21, 2021

Uh oh!

jojochuang left a comment

Uh oh!

prasad-acit commented Oct 22, 2021

Uh oh!

hadoop-yetus commented Oct 23, 2021

Uh oh!

hadoop-yetus commented Oct 23, 2021

Uh oh!

jojochuang commented Oct 25, 2021

Uh oh!

prasad-acit commented Oct 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

prasad-acit commented Oct 21, 2021

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Oct 21, 2021

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

prasad-acit commented Oct 22, 2021

Uh oh!

hadoop-yetus commented Oct 23, 2021

Uh oh!

hadoop-yetus commented Oct 23, 2021

Uh oh!

jojochuang commented Oct 25, 2021

Uh oh!

prasad-acit commented Oct 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants