Skip to content

Conversation

@pjfanning
Copy link
Member

Description of PR

HADOOP-19123

How was this patch tested?

CI build

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@slfan1989
Copy link
Contributor

LGTM.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 42s Maven dependency ordering for branch
+1 💚 mvninstall 36m 20s trunk passed
+1 💚 compile 19m 3s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 17m 41s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 mvnsite 22m 0s trunk passed
+1 💚 javadoc 8m 53s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 7m 45s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 shadedclient 53m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
+1 💚 mvninstall 34m 34s the patch passed
+1 💚 compile 18m 21s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 18m 21s the patch passed
+1 💚 compile 17m 21s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 javac 17m 21s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 17m 5s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 47s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 7m 40s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 shadedclient 55m 9s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 772m 21s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 31s The patch does not generate ASF License warnings.
1087m 35s
Reason Tests
Failed junit tests hadoop.hdfs.TestRollingUpgrade
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6661/1/artifact/out/Dockerfile
GITHUB PR #6661
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 6c928821c0b5 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f0453ee
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6661/1/testReport/
Max. process+thread count 3204 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6661/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn ayushtkn merged commit 1357bb1 into apache:trunk Apr 2, 2024
asfgit pushed a commit that referenced this pull request Apr 2, 2024
…). Contributed by PJ Fanning

Reviewed-by: Shilun Fan <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
prabhjyotsingh pushed a commit to acceldata-io/hadoop that referenced this pull request Feb 6, 2025
…to CVE (apache#6661). Contributed by PJ Fanning

Reviewed-by: Shilun Fan <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
(cherry picked from commit 1357bb1)
prabhjyotsingh added a commit to acceldata-io/hadoop that referenced this pull request Feb 6, 2025
…to CVE (apache#6661). Contributed by PJ Fanning (#82)

Reviewed-by: Shilun Fan <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
(cherry picked from commit 1357bb1)

Co-authored-by: PJ Fanning <[email protected]>
prabhjyotsingh added a commit to acceldata-io/hadoop that referenced this pull request Feb 6, 2025
…to CVE (apache#6661). Contributed by PJ Fanning (#82)

Reviewed-by: Shilun Fan <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
(cherry picked from commit 1357bb1)

Co-authored-by: PJ Fanning <[email protected]>
(cherry picked from commit 5303217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants