HADOOP-17138. Fix spotbugs warnings surfaced after upgrade to 4.0.6.

[tasanuma]

…(#2155)

(cherry picked from commit 1b29c9b)

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

[tasanuma]

There are some spotbugs warnings in #2800.

As branch-3.2 uses spotbugs after HADOOP-16870, we need to backport HADOOP-17138 to branch-3.2.

[goiri]

Dead local store?
Can someone educate me on why this is an issue?

[aajisaka]

This change is a workaround for the bug of the javac compiler.
spotbugs/spotbugs#571 (comment)

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	9m 23s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.2 Compile Tests _
+0 🆗	mvndep	3m 58s		Maven dependency ordering for branch
+1 💚	mvninstall	23m 44s		branch-3.2 passed
+1 💚	compile	15m 32s		branch-3.2 passed
+1 💚	checkstyle	2m 32s		branch-3.2 passed
+1 💚	mvnsite	8m 43s		branch-3.2 passed
+1 💚	javadoc	5m 57s		branch-3.2 passed
-1 ❌	spotbugs	9m 56s	/branch-spotbugs-hadoop-yarn-project_hadoop-yarn-warnings.html	hadoop-yarn-project/hadoop-yarn in branch-3.2 has 2 extant spotbugs warnings.
-1 ❌	spotbugs	1m 52s	/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html	hadoop-common-project/hadoop-common in branch-3.2 has 2 extant spotbugs warnings.
-1 ❌	spotbugs	2m 45s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html	hadoop-hdfs-project/hadoop-hdfs in branch-3.2 has 4 extant spotbugs warnings.
-1 ❌	spotbugs	3m 49s	/branch-spotbugs-hadoop-mapreduce-project-warnings.html	hadoop-mapreduce-project in branch-3.2 has 2 extant spotbugs warnings.
-1 ❌	spotbugs	0m 45s	/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html	hadoop-tools/hadoop-sls in branch-3.2 has 1 extant spotbugs warnings.
-1 ❌	spotbugs	0m 44s	/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests-warnings.html	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests in branch-3.2 has 2 extant spotbugs warnings.
+1 💚	shadedclient	12m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for patch
+1 💚	mvninstall	9m 14s		the patch passed
+1 💚	compile	14m 53s		the patch passed
+1 💚	javac	14m 53s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 27s		the patch passed
+1 💚	mvnsite	9m 3s		the patch passed
+1 💚	xml	0m 3s		The patch has no ill-formed XML file.
+1 💚	javadoc	5m 57s		the patch passed
+1 💚	spotbugs	2m 2s		hadoop-common-project/hadoop-common generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	spotbugs	2m 55s		hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚	spotbugs	10m 5s		hadoop-yarn-project/hadoop-yarn generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	spotbugs	0m 54s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	spotbugs	4m 0s		hadoop-mapreduce-project generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	spotbugs	0m 58s		hadoop-tools/hadoop-sls generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	shadedclient	13m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	15m 41s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	unit	172m 25s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
-1 ❌	unit	48m 49s	/patch-unit-hadoop-yarn-project_hadoop-yarn.txt	hadoop-yarn in the patch failed.
+1 💚	unit	12m 41s		hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
-1 ❌	unit	20m 10s	/patch-unit-hadoop-mapreduce-project.txt	hadoop-mapreduce-project in the patch failed.
+1 💚	unit	11m 8s		hadoop-sls in the patch passed.
+1 💚	asflicense	1m 5s		The patch does not generate ASF License warnings.
		463m 50s

Reason	Tests
Failed junit tests	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.TestCompressorDecompressor
	hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized
	hadoop.yarn.server.webproxy.amfilter.TestAmFilter
	hadoop.yarn.server.webproxy.TestWebAppProxyServlet
	hadoop.mapreduce.split.TestJobSplitWriterWithEC

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/Dockerfile
GITHUB PR	#2806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml
uname	Linux cdc60bc9fdaf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.2 / 5a68e20
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/testReport/
Max. process+thread count	2590 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project hadoop-tools/hadoop-sls U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[tasanuma]

Thanks for your review, @aajisaka. The failed tests succeeded in my local environment.