Skip to content

HADOOP-17138. Fix spotbugs warnings surfaced after upgrade to 4.0.6. #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iwasakims merged 2 commits into from
Jul 22, 2020
Merged

HADOOP-17138. Fix spotbugs warnings surfaced after upgrade to 4.0.6. #2155

iwasakims merged 2 commits into from
Jul 22, 2020

Conversation

@iwasakims
Copy link
Member

@iwasakims iwasakims commented Jul 20, 2020

Please refer to comments of HADOOP-17138 for the description.

@iwasakims
Copy link
Member Author

iwasakims commented Jul 20, 2020

The patch cleared all spotbugs warnings on my local.

$ mvn clean install findbugs:findbugs -DskipTests -DskipShade
$ find . -name findbugsXml.xml | xargs -n 1 /opt/spotbugs-4.0.6/bin/convertXmlToText -longBugCodes

@aajisaka
Copy link
Member

aajisaka commented Jul 21, 2020

Thank you @iwasakims for the PR.

How about fixing DLS_DEAD_LOCAL_STORE instead of ignoring the warning?
For example, in FSEditLogLoader#incrOpCount

-      holder.held++;
+      holder.held = holder.held + 1;

fixes the warning and removes unnecessary operations.

I ran javap -c -p to the class and found the unnecessary operations even in OpenJDK 11.0.7.

@hadoop-yetus
Copy link

hadoop-yetus commented Jul 21, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for branch
+1 💚 mvninstall 19m 49s trunk passed
+1 💚 compile 20m 30s trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 compile 17m 28s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 2m 38s trunk passed
+1 💚 mvnsite 10m 40s trunk passed
+1 💚 shadedclient 27m 42s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 32s hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 37s hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 36s hadoop-yarn in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 30s hadoop-mapreduce-project in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 27s hadoop-sls in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 26s hadoop-cos in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 5m 49s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 0m 40s Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌ findbugs 1m 57s hadoop-common-project/hadoop-common in trunk has 2 extant findbugs warnings.
-1 ❌ findbugs 2m 52s hadoop-hdfs-project/hadoop-hdfs in trunk has 4 extant findbugs warnings.
-1 ❌ findbugs 11m 8s hadoop-yarn-project/hadoop-yarn in trunk has 2 extant findbugs warnings.
-1 ❌ findbugs 0m 43s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests in trunk has 2 extant findbugs warnings.
-1 ❌ findbugs 3m 53s hadoop-mapreduce-project in trunk has 2 extant findbugs warnings.
-1 ❌ findbugs 0m 48s hadoop-tools/hadoop-sls in trunk has 1 extant findbugs warnings.
-1 ❌ findbugs 0m 39s hadoop-cloud-storage-project/hadoop-cos in trunk has 1 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 9m 19s the patch passed
+1 💚 compile 18m 45s the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 javac 18m 45s the patch passed
+1 💚 compile 16m 40s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 javac 16m 40s the patch passed
+1 💚 checkstyle 2m 41s the patch passed
+1 💚 mvnsite 10m 44s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 7s The patch has no ill-formed XML file.
+1 💚 shadedclient 13m 39s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 33s hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 38s hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 36s hadoop-yarn in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 30s hadoop-mapreduce-project in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 27s hadoop-sls in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 26s hadoop-cos in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 5m 49s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 2m 7s hadoop-common-project/hadoop-common generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 findbugs 3m 6s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚 findbugs 12m 37s hadoop-yarn-project/hadoop-yarn generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 findbugs 0m 51s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 findbugs 4m 3s hadoop-mapreduce-project generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 findbugs 0m 54s hadoop-tools/hadoop-sls generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚 findbugs 0m 48s hadoop-cloud-storage-project/hadoop-cos generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 💚 unit 9m 13s hadoop-common in the patch passed.
-1 ❌ unit 100m 51s hadoop-hdfs in the patch passed.
-1 ❌ unit 211m 57s hadoop-yarn in the patch passed.
+1 💚 unit 13m 12s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
-1 ❌ unit 157m 1s hadoop-mapreduce-project in the patch passed.
-1 ❌ unit 11m 18s hadoop-sls in the patch passed.
+1 💚 unit 1m 3s hadoop-cos in the patch passed.
-1 ❌ asflicense 1m 20s The patch generated 2 ASF License warnings.
734m 59s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
hadoop.hdfs.TestGetFileChecksum
hadoop.hdfs.server.namenode.TestNamenodeStorageDirectives
hadoop.hdfs.TestDFSStripedInputStream
hadoop.hdfs.server.balancer.TestBalancer
hadoop.hdfs.TestFileChecksum
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.yarn.service.TestYarnNativeServices
hadoop.yarn.applications.distributedshell.TestDistributedShell
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption
hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy
hadoop.mapred.TestJobEndNotifier
hadoop.yarn.sls.appmaster.TestAMSimulator
hadoop.yarn.sls.TestReservationSystemInvariants
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/Dockerfile
GITHUB PR #2155
Optional Tests dupname asflicense xml compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 08a1f62e6b01 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / f2033de
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-javadoc-hadoop-mapreduce-project-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-javadoc-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-javadoc-hadoop-cloud-storage-project_hadoop-cos-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-findbugs-hadoop-mapreduce-project-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/branch-findbugs-hadoop-cloud-storage-project_hadoop-cos-warnings.html
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-javadoc-hadoop-mapreduce-project-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-javadoc-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-javadoc-hadoop-cloud-storage-project_hadoop-cos-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-unit-hadoop-mapreduce-project.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-unit-hadoop-tools_hadoop-sls.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 4131 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project hadoop-tools/hadoop-sls hadoop-cloud-storage-project/hadoop-cos U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@iwasakims
Copy link
Member Author

iwasakims commented Jul 21, 2020

How about fixing DLS_DEAD_LOCAL_STORE instead of ignoring the warning?

Thanks, @aajisaka. It would be better to fix the code and make the diff smaller. I thought filtering the warning via excludeFilterFile would make the intent clear but it is ad hoc workaround for compiler specific issue anyway. JIRA should be referred for the background. I updated the patch.

@hadoop-yetus
Copy link

hadoop-yetus commented Jul 21, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for branch
+1 💚 mvninstall 23m 58s trunk passed
+1 💚 compile 26m 8s trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 compile 23m 1s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 3m 31s trunk passed
+1 💚 mvnsite 12m 51s trunk passed
+1 💚 shadedclient 34m 54s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 37s hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 42s hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 41s hadoop-yarn in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 31s hadoop-mapreduce-project in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 28s hadoop-sls in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 27s hadoop-cos in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 6m 30s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 0m 43s Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌ findbugs 2m 24s hadoop-common-project/hadoop-common in trunk has 2 extant findbugs warnings.
-1 ❌ findbugs 3m 38s hadoop-hdfs-project/hadoop-hdfs in trunk has 4 extant findbugs warnings.
-1 ❌ findbugs 15m 31s hadoop-yarn-project/hadoop-yarn in trunk has 2 extant findbugs warnings.
-1 ❌ findbugs 0m 48s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests in trunk has 2 extant findbugs warnings.
-1 ❌ findbugs 4m 49s hadoop-mapreduce-project in trunk has 2 extant findbugs warnings.
-1 ❌ findbugs 0m 46s hadoop-tools/hadoop-sls in trunk has 1 extant findbugs warnings.
-1 ❌ findbugs 0m 41s hadoop-cloud-storage-project/hadoop-cos in trunk has 1 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 9m 50s the patch passed
+1 💚 compile 20m 40s the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 javac 20m 40s the patch passed
+1 💚 compile 17m 48s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 javac 17m 48s the patch passed
+1 💚 checkstyle 2m 48s the patch passed
+1 💚 mvnsite 11m 10s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 9s The patch has no ill-formed XML file.
+1 💚 shadedclient 14m 29s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 31s hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 34s hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 32s hadoop-yarn in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 31s hadoop-mapreduce-project in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 24s hadoop-sls in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javadoc 0m 23s hadoop-cos in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 5m 53s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 2m 9s hadoop-common-project/hadoop-common generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 findbugs 3m 2s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚 findbugs 12m 24s hadoop-yarn-project/hadoop-yarn generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 findbugs 0m 54s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 findbugs 4m 26s hadoop-mapreduce-project generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 findbugs 0m 56s hadoop-tools/hadoop-sls generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚 findbugs 0m 49s hadoop-cloud-storage-project/hadoop-cos generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 💚 unit 9m 37s hadoop-common in the patch passed.
-1 ❌ unit 103m 57s hadoop-hdfs in the patch passed.
-1 ❌ unit 229m 48s hadoop-yarn in the patch passed.
+1 💚 unit 13m 46s hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.
-1 ❌ unit 150m 0s hadoop-mapreduce-project in the patch passed.
+1 💚 unit 12m 37s hadoop-sls in the patch passed.
+1 💚 unit 1m 2s hadoop-cos in the patch passed.
-1 ❌ asflicense 1m 22s The patch generated 1 ASF License warnings.
786m 18s
Reason Tests
Failed junit tests hadoop.hdfs.TestWriteReadStripedFile
hadoop.hdfs.server.namenode.TestCheckpoint
hadoop.hdfs.security.TestDelegationToken
hadoop.hdfs.TestDistributedFileSystem
hadoop.hdfs.web.TestWebHdfsWithRestCsrfPreventionFilter
hadoop.hdfs.server.namenode.web.resources.TestWebHdfsCreatePermissions
hadoop.hdfs.security.TestDelegationTokenForProxyUser
hadoop.hdfs.qjournal.TestSecureNNWithQJM
hadoop.hdfs.web.TestFSMainOperationsWebHdfs
hadoop.hdfs.server.namenode.TestFSImage
hadoop.hdfs.server.namenode.TestStorageRestore
hadoop.hdfs.web.TestWebHDFS
hadoop.hdfs.server.namenode.TestPersistentStoragePolicySatisfier
hadoop.fs.TestSymlinkHdfsFileContext
hadoop.fs.TestSWebHdfsFileContextMainOperations
hadoop.hdfs.web.TestHttpsFileSystem
hadoop.fs.TestSymlinkHdfsFileSystem
hadoop.hdfs.TestTrashWithSecureEncryptionZones
hadoop.hdfs.web.TestWebHDFSXAttr
hadoop.hdfs.TestEncryptionZonesWithKMS
hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy
hadoop.hdfs.server.namenode.TestBackupNode
hadoop.hdfs.server.namenode.TestReencryptionWithKMS
hadoop.hdfs.TestEncryptionZones
hadoop.hdfs.web.TestWebHDFSForHA
hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized
hadoop.hdfs.tools.TestViewFSStoragePolicyCommands
hadoop.hdfs.server.namenode.TestStartup
hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR
hadoop.hdfs.TestAclsEndToEnd
hadoop.hdfs.web.TestWebHdfsFileSystemContract
hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
hadoop.hdfs.server.namenode.TestCacheDirectives
hadoop.hdfs.web.TestWebHdfsTokens
hadoop.hdfs.tools.TestWebHDFSStoragePolicyCommands
hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade
hadoop.hdfs.server.namenode.TestNameEditsConfigs
hadoop.hdfs.TestSecureEncryptionZoneWithKMS
hadoop.hdfs.web.TestWebHDFSAcl
hadoop.hdfs.server.namenode.TestAuditLogs
hadoop.hdfs.web.TestWebHdfsUrl
hadoop.fs.TestWebHdfsFileContextMainOperations
hadoop.hdfs.TestRollingUpgrade
hadoop.tools.TestHdfsConfigFields
hadoop.yarn.applications.distributedshell.TestDistributedShell
hadoop.yarn.client.TestRMFailover
hadoop.yarn.webapp.util.TestWebServiceClient
hadoop.yarn.webapp.TestWebApp
hadoop.yarn.server.webproxy.TestWebAppProxyServlet
hadoop.yarn.server.timeline.webapp.TestTimelineWebServicesWithSSL
hadoop.yarn.server.timeline.security.TestTimelineAuthenticationFilterForV1
hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication
hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication
hadoop.yarn.server.resourcemanager.metrics.TestCombinedSystemMetricsPublisher
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2
hadoop.yarn.server.timelineservice.TestTimelineServiceClientIntegration
hadoop.mapreduce.v2.app.webapp.TestAMWebApp
hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler
hadoop.mapred.TestMRTimelineEventHandling
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/Dockerfile
GITHUB PR #2155
Optional Tests dupname asflicense xml compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 02d7a4ff2535 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d57462f
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-javadoc-hadoop-mapreduce-project-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-javadoc-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-javadoc-hadoop-cloud-storage-project_hadoop-cos-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-findbugs-hadoop-mapreduce-project-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/branch-findbugs-hadoop-cloud-storage-project_hadoop-cos-warnings.html
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-javadoc-hadoop-mapreduce-project-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-javadoc-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-javadoc-hadoop-cloud-storage-project_hadoop-cos-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-unit-hadoop-mapreduce-project.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 4195 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project hadoop-tools/hadoop-sls hadoop-cloud-storage-project/hadoop-cos U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2155/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@iwasakims
Copy link
Member Author

iwasakims commented Jul 22, 2020

Tests failed due to web authentication error. The patch does not touch relevant code.

@aajisaka aajisaka self-requested a review July 22, 2020 04:17
aajisaka
aajisaka approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the patch. +1.

@iwasakims iwasakims merged commit 1b29c9b into apache:trunk Jul 22, 2020
@iwasakims
Copy link
Member Author

iwasakims commented Jul 22, 2020

I merged this. Thanks, @aajisaka.

aajisaka pushed a commit to aajisaka/hadoop that referenced this pull request Dec 10, 2020
@iwasakims @aajisaka
HADOOP-17138. Fix spotbugs warnings surfaced after upgrade to 4.0.6. (a…
1e96a50 
…pache#2155)

(cherry picked from commit 1b29c9b)
@aajisaka aajisaka mentioned this pull request Dec 10, 2020
Merged
aajisaka added a commit that referenced this pull request Dec 11, 2020
@aajisaka @iwasakims
HADOOP-17138. Fix spotbugs warnings surfaced after upgrade to 4.0.6. (#…
71bda1a 
…2155) (#2538)

(cherry picked from commit 1b29c9b)

Co-authored-by: Masatake Iwasaki <[email protected]>
tasanuma pushed a commit to tasanuma/hadoop that referenced this pull request Mar 23, 2021
@iwasakims @tasanuma
HADOOP-17138. Fix spotbugs warnings surfaced after upgrade to 4.0.6. (a…
5a68e20 
…pache#2155)

(cherry picked from commit 1b29c9b)
@tasanuma tasanuma mentioned this pull request Mar 23, 2021
Merged
tasanuma added a commit that referenced this pull request Mar 24, 2021
@tasanuma @iwasakims
HADOOP-17138. Fix spotbugs warnings surfaced after upgrade to 4.0.6. (#…
9060972 
…2155) (#2806)

(cherry picked from commit 1b29c9b)

Co-authored-by: Masatake Iwasaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aajisaka aajisaka aajisaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iwasakims @aajisaka @hadoop-yetus