Skip to content

HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi… #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoyuyao merged 1 commit into from
Sep 9, 2019
Merged

HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi… #1373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...e-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ public void verifyRaftGroupIdGenerationWithCustomOmServiceId() throws
.setOMServiceId(customOmServiceId)
.build();
// Starts a single node Ratis server
omRatisServer.stop();
OzoneManagerRatisServer newOmRatisServer = OzoneManagerRatisServer
Copy link
Contributor Author

@xiaoyuyao xiaoyuyao Sep 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChenSammi omRatisServer is started at the begin of each test case and stop after that. However in this new test case, it started a different OzoneManagerRatisServer named newOmRatisServer, it has to be stopped explicitly to avoid leak. Also, the omRatisServer has to be stopped before newOmRatisServer is started to avoid metric registration confliction.

.newOMRatisServer(newConf, ozoneManager, nodeDetails,
Collections.emptyList());
Expand All @@ -219,6 +220,7 @@ public void verifyRaftGroupIdGenerationWithCustomOmServiceId() throws
RaftGroupId raftGroupId = newOmRatisServer.getRaftGroup().getGroupId();
Assert.assertEquals(uuid, raftGroupId.getUuid());
Assert.assertEquals(raftGroupId.toByteString().size(), 16);
newOmRatisServer.stop();
}


Expand Down