HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi… #1373

xiaoyuyao · 2019-08-28T23:32:56Z

…aoyu Yao.

hadoop-yetus · 2019-08-29T04:10:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	50	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	667	trunk passed
+1	compile	438	trunk passed
+1	checkstyle	80	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	958	branch has no errors when building and testing our client artifacts.
+1	javadoc	172	trunk passed
0	spotbugs	450	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	657	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	526	the patch passed
+1	compile	397	the patch passed
+1	javac	397	the patch passed
+1	checkstyle	77	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	688	patch has no errors when building and testing our client artifacts.
+1	javadoc	174	the patch passed
+1	findbugs	638	the patch passed
		_ Other Tests _
+1	unit	319	hadoop-hdds in the patch passed.
-1	unit	1823	hadoop-ozone in the patch failed.
+1	asflicense	50	The patch does not generate ASF License warnings.
		7895

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.scm.node.TestQueryNode
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.TestSecureOzoneCluster
	hadoop.ozone.TestStorageContainerManager
	hadoop.ozone.TestOzoneConfigurationFields
	hadoop.ozone.client.rpc.TestCommitWatcher

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1373/1/artifact/out/Dockerfile
GITHUB PR	#1373
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ae957f9b022e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `872cdf4`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1373/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1373/1/testReport/
Max. process+thread count	5231 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1373/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-09-02T23:13:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	76	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	628	trunk passed
+1	compile	374	trunk passed
+1	checkstyle	72	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	939	branch has no errors when building and testing our client artifacts.
+1	javadoc	172	trunk passed
0	spotbugs	432	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	631	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	552	the patch passed
+1	compile	372	the patch passed
+1	javac	372	the patch passed
+1	checkstyle	76	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	743	patch has no errors when building and testing our client artifacts.
+1	javadoc	167	the patch passed
+1	findbugs	649	the patch passed
		_ Other Tests _
+1	unit	283	hadoop-hdds in the patch passed.
-1	unit	1705	hadoop-ozone in the patch failed.
+1	asflicense	45	The patch does not generate ASF License warnings.
		7640

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestSecureOzoneManager
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1373/2/artifact/out/Dockerfile
GITHUB PR	#1373
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 8a011fbc359a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `915cbc9`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1373/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1373/2/testReport/
Max. process+thread count	5356 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1373/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

ChenSammi · 2019-09-03T11:59:00Z

@xiaoyuyao, Xiaoyu, I cannot reproduce this test failure locally. Any extra step to reproduce it?

xiaoyuyao · 2019-09-03T18:25:00Z

Just try repeat the test run more than 1 times in IntelliJ, you will be able repro the metrics leak.

ChenSammi · 2019-09-04T06:50:14Z

I rerun the test dozens of times, sill cannot reproduce the issue. Don't know why.

xiaoyuyao · 2019-09-04T17:07:36Z

In the test Run/Debug Configuration, Choose "Repeat": "Until Failure" for the test case
TestOzoneManagerRatisServer#verifyRaftGroupIdGenerationWithCustomOmServiceId

xiaoyuyao · 2019-09-05T20:43:38Z

...zone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisServer.java

        .build();
    // Starts a single node Ratis server
+    omRatisServer.stop();
    OzoneManagerRatisServer newOmRatisServer = OzoneManagerRatisServer


@ChenSammi omRatisServer is started at the begin of each test case and stop after that. However in this new test case, it started a different OzoneManagerRatisServer named newOmRatisServer, it has to be stopped explicitly to avoid leak. Also, the omRatisServer has to be stopped before newOmRatisServer is started to avoid metric registration confliction.

adoroszlai

Thanks @xiaoyuyao for working on fixing this unit test.

hanishakoneru · 2019-09-09T22:15:36Z

Change LGTM. +1.

…aoyu Yao. (apache#1373)

HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi…

430b003

…aoyu Yao.

xiaoyuyao self-assigned this Aug 28, 2019

xiaoyuyao added the ozone label Aug 28, 2019

ChenSammi closed this Sep 4, 2019

ChenSammi reopened this Sep 4, 2019

This comment has been minimized.

Sign in to view

xiaoyuyao commented Sep 5, 2019

View reviewed changes

adoroszlai approved these changes Sep 9, 2019

View reviewed changes

xiaoyuyao merged commit 650c4ce into apache:trunk Sep 9, 2019

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi…

944e160

…aoyu Yao. (apache#1373)

RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020

HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi…

a3dfa7c

…aoyu Yao. (apache#1373)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi… #1373

HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi… #1373

Uh oh!

xiaoyuyao commented Aug 28, 2019

Uh oh!

hadoop-yetus commented Aug 29, 2019

Uh oh!

hadoop-yetus commented Sep 2, 2019

Uh oh!

ChenSammi commented Sep 3, 2019 •

edited

Loading

Uh oh!

xiaoyuyao commented Sep 3, 2019

Uh oh!

ChenSammi commented Sep 4, 2019

Uh oh!

xiaoyuyao commented Sep 4, 2019

Uh oh!

This comment has been minimized.

xiaoyuyao Sep 5, 2019 •

edited

Loading

Uh oh!

adoroszlai left a comment

Uh oh!

hanishakoneru commented Sep 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi… #1373

HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi… #1373

Uh oh!

Conversation

xiaoyuyao commented Aug 28, 2019

Uh oh!

hadoop-yetus commented Aug 29, 2019

Uh oh!

hadoop-yetus commented Sep 2, 2019

Uh oh!

ChenSammi commented Sep 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaoyuyao commented Sep 3, 2019

Uh oh!

ChenSammi commented Sep 4, 2019

Uh oh!

xiaoyuyao commented Sep 4, 2019

Uh oh!

This comment has been minimized.

xiaoyuyao Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adoroszlai left a comment

Choose a reason for hiding this comment

Uh oh!

hanishakoneru commented Sep 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ChenSammi commented Sep 3, 2019 •

edited

Loading

xiaoyuyao Sep 5, 2019 •

edited

Loading