Hessian support attachments and add log4j2 support. #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2、添加log4j2的支持 3、修复hessian attachment 隐形参数失效问题
|
|
2、添加log4j2的支持 3、修复hessian attachment 隐形参数失效问题
2、添加log4j2的支持 3、修复hessian attachment 隐形参数失效问题
2、添加log4j2的支持 3、修复hessian attachment 隐形参数失效问题
|
Would you please separate this two features? We prefer to have each PR focus on solution for a single |
chickenlj
added
type/feature
status/waiting-for-feedback
chickenlj
changed the title
+1 It is too complicated to review this pull request, please keep it simple. |
|
I am considering about this. #1801 On the provider side, a HessianFilter is not a good way. I will try to restore context in HessianHandler. |
|
@sc834466168 IMO, you could submit a new PR for supporting log4j2. |
|
Hessian attachments has been supported with #1801. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、修复hessian 重载方法时报错问题
http://blog.csdn.net/sanfye/article/details/49390493
2、添加log4j2的支持
与原log2j配置一致
添加配置dubbo.log4j.console, 是否添加输出至控制台
3、修复hessian 隐形参数失效问题
RpcContext中的getAttachments无法获取到消费者端传来的参数
a) 未设置attachments参数
b)debug过程中发现被InvokerInvocationHandler类重置
暂时想到的办法是在httpclient中添加header进行传输, 由于上述b重试了 RpcInvocation类, ContextFilter无法获取到attachments, 临时解决方案是HessianProtocol类中设置ThreadLocal保证线程安全, 在使用HessianFilter进行参数设置