-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support generic invoke for http/hessian protocol #1768 #1801
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
============================================
- Coverage 40.43% 40.34% -0.09%
- Complexity 4415 4443 +28
============================================
Files 628 643 +15
Lines 30082 30533 +451
Branches 5319 5379 +60
============================================
+ Hits 12164 12320 +156
- Misses 15994 16279 +285
- Partials 1924 1934 +10
Continue to review full report at Codecov.
|
I haven't find the way to ship context from consumer to provider through HessianProxyFactory. An ugly way is to use URL query parameter, but it has a length limit. |
Another way is using HTTP Header to ship RpcContext. I will try it later. |
…to http-generic-support
Because of the commits are not clear, so I'll start a new PR, this one will be closed. |
The new PR is #1827 |
What is the purpose of the change
The corresponding issue is #1768. This PR support generic invocation in HttpProtocol/HessianProtocol.
Brief changelog
To export additional GenericService in HessianProtocol/HttpProtocol for supporting normal/nativejava/bean types of generic invocation.
Verifying this change
HttpProtocolTest/HessianProtocolTest is the corresponding unit tests.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.